Skip to content

Commit 21afb61

Browse files
authored
Enable Spark UT RapidsMathExpressionsSuite, RapidsMiscFunctionsSuite on 330 (#13748)
Enable Spark UT on v330 with below suites RapidsMathExpressionsSuite RapidsMiscFunctionsSuite Signed-off-by: Gary Shen <gashen@nvidia.com>
1 parent 93b0437 commit 21afb61

File tree

3 files changed

+63
-1
lines changed

3 files changed

+63
-1
lines changed
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
/*
2+
* Copyright (c) 2025, NVIDIA CORPORATION.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* http://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
17+
/*** spark-rapids-shim-json-lines
18+
{"spark": "330"}
19+
spark-rapids-shim-json-lines ***/
20+
package org.apache.spark.sql.rapids.suites
21+
22+
import org.apache.spark.sql.catalyst.expressions.MathExpressionsSuite
23+
import org.apache.spark.sql.rapids.utils.RapidsTestsTrait
24+
25+
class RapidsMathExpressionsSuite extends MathExpressionsSuite with RapidsTestsTrait {
26+
// Minimal inheritance - GPU verification is automatic!
27+
}
28+
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
/*
2+
* Copyright (c) 2025, NVIDIA CORPORATION.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* http://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
17+
/*** spark-rapids-shim-json-lines
18+
{"spark": "330"}
19+
spark-rapids-shim-json-lines ***/
20+
package org.apache.spark.sql.rapids.suites
21+
22+
import org.apache.spark.sql.MiscFunctionsSuite
23+
import org.apache.spark.sql.rapids.utils.RapidsSQLTestsTrait
24+
25+
class RapidsMiscFunctionsSuite extends MiscFunctionsSuite with RapidsSQLTestsTrait {
26+
// Minimal inheritance - GPU verification is automatic!
27+
}

tests/src/test/spark330/scala/org/apache/spark/sql/rapids/utils/RapidsTestSettings.scala

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
spark-rapids-shim-json-lines ***/
2020
package org.apache.spark.sql.rapids.utils
2121

22-
import org.apache.spark.sql.rapids.suites.{RapidsCastSuite, RapidsDataFrameAggregateSuite, RapidsJsonExpressionsSuite, RapidsJsonFunctionsSuite, RapidsJsonSuite, RapidsMathFunctionsSuite, RapidsParquetAvroCompatibilitySuite, RapidsParquetColumnIndexSuite, RapidsParquetCompressionCodecPrecedenceSuite, RapidsParquetDeltaByteArrayEncodingSuite, RapidsParquetDeltaEncodingInteger, RapidsParquetDeltaEncodingLong, RapidsParquetDeltaLengthByteArrayEncodingSuite, RapidsParquetFieldIdIOSuite, RapidsParquetFieldIdSchemaSuite, RapidsParquetFileFormatSuite, RapidsParquetInteroperabilitySuite, RapidsParquetPartitionDiscoverySuite, RapidsParquetProtobufCompatibilitySuite, RapidsParquetQuerySuite, RapidsParquetRebaseDatetimeSuite, RapidsParquetSchemaPruningSuite, RapidsParquetSchemaSuite, RapidsParquetThriftCompatibilitySuite, RapidsParquetVectorizedSuite, RapidsRegexpExpressionsSuite, RapidsStringExpressionsSuite, RapidsStringFunctionsSuite}
22+
import org.apache.spark.sql.rapids.suites.{RapidsCastSuite, RapidsDataFrameAggregateSuite, RapidsJsonExpressionsSuite, RapidsJsonFunctionsSuite, RapidsJsonSuite, RapidsMathExpressionsSuite, RapidsMathFunctionsSuite, RapidsMiscFunctionsSuite, RapidsParquetAvroCompatibilitySuite, RapidsParquetColumnIndexSuite, RapidsParquetCompressionCodecPrecedenceSuite, RapidsParquetDeltaByteArrayEncodingSuite, RapidsParquetDeltaEncodingInteger, RapidsParquetDeltaEncodingLong, RapidsParquetDeltaLengthByteArrayEncodingSuite, RapidsParquetFieldIdIOSuite, RapidsParquetFieldIdSchemaSuite, RapidsParquetFileFormatSuite, RapidsParquetInteroperabilitySuite, RapidsParquetPartitionDiscoverySuite, RapidsParquetProtobufCompatibilitySuite, RapidsParquetQuerySuite, RapidsParquetRebaseDatetimeSuite, RapidsParquetSchemaPruningSuite, RapidsParquetSchemaSuite, RapidsParquetThriftCompatibilitySuite, RapidsParquetVectorizedSuite, RapidsRegexpExpressionsSuite, RapidsStringExpressionsSuite, RapidsStringFunctionsSuite}
2323

2424
// Some settings' line length exceeds 100
2525
// scalastyle:off line.size.limit
@@ -59,9 +59,16 @@ class RapidsTestSettings extends BackendTestSettings {
5959
.exclude("Applying schemas", KNOWN_ISSUE("https://github.com/NVIDIA/spark-rapids/issues/10773"))
6060
.exclude("Loading a JSON dataset from a text file with SQL", KNOWN_ISSUE("https://github.com/NVIDIA/spark-rapids/issues/10773"))
6161
.exclude("Loading a JSON dataset from a text file", KNOWN_ISSUE("https://github.com/NVIDIA/spark-rapids/issues/10773"))
62+
enableSuite[RapidsMathExpressionsSuite]
63+
.exclude("conv", KNOWN_ISSUE("https://github.com/NVIDIA/spark-rapids/issues/13737"))
64+
.exclude("log10", KNOWN_ISSUE("https://github.com/NVIDIA/spark-rapids/issues/13738"))
65+
.exclude("log2", KNOWN_ISSUE("https://github.com/NVIDIA/spark-rapids/issues/13740"))
66+
.exclude("binary log", KNOWN_ISSUE("https://github.com/NVIDIA/spark-rapids/issues/13741"))
67+
.exclude("round/bround/floor/ceil", KNOWN_ISSUE("https://github.com/NVIDIA/spark-rapids/issues/13747"))
6268
enableSuite[RapidsMathFunctionsSuite]
6369
.exclude("SPARK-33428 conv function shouldn't raise error if input string is too big", KNOWN_ISSUE("https://github.com/NVIDIA/spark-rapids/issues/11142"))
6470
.exclude("SPARK-36229 conv should return result equal to -1 in base of toBase", KNOWN_ISSUE("https://github.com/NVIDIA/spark-rapids/issues/11142"))
71+
enableSuite[RapidsMiscFunctionsSuite]
6572
enableSuite[RapidsParquetAvroCompatibilitySuite]
6673
.exclude("SPARK-10136 array of primitive array", KNOWN_ISSUE("https://github.com/NVIDIA/spark-rapids/issues/11592"))
6774
enableSuite[RapidsParquetColumnIndexSuite]

0 commit comments

Comments
 (0)