refactor(app/outbound): duration middleware uses BodyWithEosFn
#4306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BodyWithEosFn
0b165b6 to
39bf89f
Compare
Base automatically changed from
kate/decouple-record-response.pt-2.app-outbound-integration
to
main
November 17, 2025 19:10
a88366e to
a7e908a
Compare
this commit introduces clone and copy implementations for the
`EosRef<'a, E>` type used to inspect and classify the outcome of a
request or response body.
as the documentation comment notes in the commit below, this enum only
contains immutable references to other values: a header map or an
error. other variants are empty tags.
```rust
pub enum EosRef<'a, E = Error> {
None,
Trailers(&'a HeaderMap),
Error(&'a E),
Cancelled,
}
```
this commit makes this type implicitly clonable.
Signed-off-by: katelyn martin <kate@buoyant.io>
Signed-off-by: katelyn martin <kate@buoyant.io>
Signed-off-by: katelyn martin <kate@buoyant.io>
Signed-off-by: katelyn martin <kate@buoyant.io>
a7e908a to
1097399
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(http/body-eos):
EosRef<'a, E>is clonableSigned-off-by: katelyn martin kate@buoyant.io
refactor(http/prom):
StreamLabel::end_responseacceptsEosRefSigned-off-by: katelyn martin kate@buoyant.io
refactor(http/prom): use
BodyWithEosFnin duration middlewareSigned-off-by: katelyn martin kate@buoyant.io
refactor(http/prom):
BodyWithEosFnrecords flush timestampSigned-off-by: katelyn martin kate@buoyant.io
work in progress