Skip to content

Conversation

@karthikprasad
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs change / refactoring / dependency upgrade

Motivation and Context / Related issue

#436

How Has This Been Tested (if it applies)

[WIP] unit tests

In addition to fixing the issue, this also results in massive memory savings. See CUDA memory usage before and after this change in https://colab.research.google.com/drive/1jYpZ2uVz2UXCoj2v0Vf30uqWO2oAl3de?usp=sharing (5.7 GB --> 27MB)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@karthikprasad karthikprasad added the bug Something isn't working label Jun 9, 2022
@karthikprasad karthikprasad added this to the 1.1.3 milestone Jun 9, 2022
@karthikprasad karthikprasad requested a review from ffuuugor June 9, 2022 21:20
@karthikprasad karthikprasad self-assigned this Jun 9, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2022
@karthikprasad karthikprasad linked an issue Jun 9, 2022 that may be closed by this pull request
@facebook-github-bot
Copy link
Contributor

@karthikprasad has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@karthikprasad has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@karthikprasad has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@karthikprasad karthikprasad marked this pull request as ready for review June 10, 2022 22:33
Copy link
Contributor

@ffuuugor ffuuugor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(5.7 GB --> 27MB)

I now bestow upon you the proud title of "The Chief Metric Gaming Officer", that's a beautiful experiment design.

But in all seriousness, great change, thanks a lot!
Having to do that in every grad sampler is not ideal, but I can't see any other option either

@facebook-github-bot
Copy link
Contributor

@karthikprasad has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@karthikprasad has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opacus issue with a mix of frozen and learnable params

3 participants