restore benchmarking for dp layers and fix nightly tests #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@ffuuugor has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@ffuuugor has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
@ffuuugor has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
@ffuuugor has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
@ffuuugor has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
@ffuuugor has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, this time it should work.
See successful CircleCI run here. Normally we don't run benchmarks for every commit to save time. So here I temporarily added benchmarks to commit tests, made sure they pass and then disabled them back. CircleCI link above include previously failing microbenchmarks