Skip to content

align docstring of make_private_with_epsilon with args #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

align docstring of make_private_with_epsilon with args #526

wants to merge 1 commit into from

Conversation

@Solosneros
Copy link
Contributor

@Solosneros Solosneros commented Oct 19, 2022

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs change / refactoring / dependency upgrade

Motivation and Context / Related issue

Outdated docstring of make_private_with_epsilon.

#525

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@Solosneros Solosneros changed the title align docstrings of make_private_with_epsilon with args align docstring of make_private_with_epsilon with args Oct 19, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 19, 2022
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 21, 2022

@ffuuugor has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

ffuuugor
ffuuugor approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@ffuuugor ffuuugor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing the discrepancy and taking the time to fix it! LGTM

@Solosneros Solosneros mentioned this pull request Oct 25, 2022
Closed
karthikprasad
karthikprasad approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@karthikprasad karthikprasad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! Could you please rebase this PR; it is good to go after that.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 30, 2022

@Solosneros has updated the pull request. You must reimport the pull request before landing.

@Solosneros
Copy link
Contributor Author

Solosneros commented Nov 1, 2022

@karthikprasad All good now?

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 1, 2022

@ffuuugor has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthikprasad karthikprasad karthikprasad approved these changes

+1 more reviewer

@ffuuugor ffuuugor ffuuugor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Solosneros @facebook-github-bot @karthikprasad @ffuuugor