Skip to content

Conversation

@ParthS007
Copy link

Types of changes

  • New feature (non-breaking change which adds functionality)

Motivation and Context / Related issue

Implements automatic clipping optimizers based on the paper "Automatic Clipping: Differentially Private Deep Learning Made Easier and Stronger" (https://arxiv.org/pdf/2206.07136).

Fixes #797

How Has This Been Tested (if it applies)

  • Added unit tests in opacus/tests/automatic_clipping.py (3 tests, all passing)
  • Added distributed multi-GPU tests in opacus/tests/multigpu_automatic_clipping_test.py
  • Tested with both clipping="automatic" and clipping="automatic_per_layer" modes

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@meta-cla
Copy link

meta-cla bot commented Oct 30, 2025

Hi @ParthS007!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link

meta-cla bot commented Oct 30, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 30, 2025
@ParthS007
Copy link
Author

Request for review: @EnayatUllah

@iden-kalemaj
Copy link
Contributor

Hi Parth, thank you for your contribution, I have initiated testing.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 18935495756

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 72 of 276 (26.09%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.9%) to 76.261%

Changes Missing Coverage Covered Lines Changed/Added Lines %
opacus/optimizers/init.py 2 10 20.0%
opacus/optimizers/optimizer_automatic_clipping.py 10 38 26.32%
opacus/optimizers/ddpoptimizer_automatic_clipping.py 16 56 28.57%
opacus/tests/multigpu_automatic_clipping_test.py 28 90 31.11%
opacus/tests/automatic_clipping.py 16 82 19.51%
Totals Coverage Status
Change from base Build 19286107198: -1.9%
Covered Lines: 5744
Relevant Lines: 7532

💛 - Coveralls

@meta-codesync
Copy link

meta-codesync bot commented Nov 20, 2025

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D87577954. (Because this pull request was imported automatically, there will not be any future comments.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add automatic clipping support to Opacus

4 participants