error-code

Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>

Author: sameshai

common/vpcclient/vpcfilevolume/create_file_share_target.go

@@ -49,11 +49,8 @@ func (vs *FileShareService) CreateFileShareTarget(fileShareTargetRequest *models
 
 	req := request.PathParameter(shareIDParam, fileShareTargetRequest.ShareID)
 
-	resp, err := req.JSONBody(fileShareTargetRequest).JSONSuccess(&shareTarget).JSONError(&apiErr).Invoke()
+	_, err := req.JSONBody(fileShareTargetRequest).JSONSuccess(&shareTarget).JSONError(&apiErr).Invoke()
 	if err != nil {
-		if len(apiErr.Errors) > 0 {
-			apiErr.Errors[0].Status = resp.Status
-		}
 		return nil, err
 	}
 	ctxLogger.Info("Successfully created the file share target")

common/vpcclient/vpcfilevolume/delete_file_share.go

@@ -44,11 +44,8 @@ func (vs *FileShareService) DeleteFileShare(shareID string, ctxLogger *zap.Logge
 	request := vs.client.NewRequest(operation)
 	ctxLogger.Info("Equivalent curl command", zap.Reflect("URL", request.URL()), zap.Reflect("Operation", operation))
 
-	resp, err := request.PathParameter(shareIDParam, shareID).JSONError(&apiErr).Invoke()
+	_, err := request.PathParameter(shareIDParam, shareID).JSONError(&apiErr).Invoke()
 	if err != nil {
-		if len(apiErr.Errors) > 0 {
-			apiErr.Errors[0].Status = resp.Status
-		}
 		return err
 	}
 

common/vpcclient/vpcfilevolume/delete_file_share_target.go

@@ -51,9 +51,6 @@ func (vs *FileShareService) DeleteFileShareTarget(deleteShareTargetRequest *mode
 		if resp != nil && resp.StatusCode == http.StatusNotFound {
 			// file share target is deleted. So do not want to retry
 			ctxLogger.Info("Exit DeleteFileShareTarget", zap.Any("resp", resp.StatusCode), zap.Error(err), zap.Error(apiErr))
-			if len(apiErr.Errors) > 0 {
-				apiErr.Errors[0].Status = resp.Status
-			}
 			return resp, apiErr
 		}
 	}

common/vpcclient/vpcfilevolume/expand_volume.go

@@ -45,11 +45,8 @@ func (vs *FileShareService) ExpandVolume(shareID string, volumeTemplate *models.
 	request := vs.client.NewRequest(operation)
 	req := request.PathParameter(shareIDParam, shareID)
 	ctxLogger.Info("Equivalent curl command and payload details", zap.Reflect("URL", req.URL()), zap.Reflect("Payload", volumeTemplate), zap.Reflect("Operation", operation))
-	resp, err := req.JSONBody(volumeTemplate).JSONSuccess(&share).JSONError(&apiErr).Invoke()
+	_, err := req.JSONBody(volumeTemplate).JSONSuccess(&share).JSONError(&apiErr).Invoke()
 	if err != nil {
-		if len(apiErr.Errors) > 0 {
-			apiErr.Errors[0].Status = resp.Status
-		}
 		ctxLogger.Info("Exit Backend ExpandVolume due to error.", zap.Reflect("Error: ", err))
 		return nil, err
 	}

common/vpcclient/vpcfilevolume/get_file_share.go

@@ -46,11 +46,8 @@ func (vs *FileShareService) GetFileShare(shareID string, ctxLogger *zap.Logger)
 	ctxLogger.Info("Equivalent curl command", zap.Reflect("URL", request.URL()), zap.Reflect("Operation", operation))
 
 	req := request.PathParameter(shareIDParam, shareID)
-	resp, err := req.JSONSuccess(&share).JSONError(&apiErr).Invoke()
+	_, err := req.JSONSuccess(&share).JSONError(&apiErr).Invoke()
 	if err != nil {
-		if len(apiErr.Errors) > 0 {
-			apiErr.Errors[0].Status = resp.Status
-		}
 		return nil, err
 	}
 

common/vpcclient/vpcfilevolume/get_file_share_etag.go

@@ -48,9 +48,6 @@ func (vs *FileShareService) GetFileShareEtag(shareID string, ctxLogger *zap.Logg
 	req := request.PathParameter(shareIDParam, shareID)
 	resp, err := req.JSONSuccess(&share).JSONError(&apiErr).Invoke()
 	if err != nil {
-		if len(apiErr.Errors) > 0 {
-			apiErr.Errors[0].Status = resp.Status
-		}
 		return nil, "", err
 	}
 

common/vpcclient/vpcfilevolume/get_file_share_target.go

@@ -47,11 +47,8 @@ func (vs *FileShareService) GetFileShareTarget(shareID string, targetID string,
 
 	req := request.PathParameter(shareIDParam, shareID).PathParameter(shareTargetIDParam, targetID)
 
-	resp, err := req.JSONSuccess(&shareTarget).JSONError(&apiErr).Invoke()
+	_, err := req.JSONSuccess(&shareTarget).JSONError(&apiErr).Invoke()
 	if err != nil {
-		if len(apiErr.Errors) > 0 {
-			apiErr.Errors[0].Status = resp.Status
-		}
 		return nil, err
 	}
 

common/vpcclient/vpcfilevolume/list_file_share_targets.go

@@ -55,11 +55,8 @@ func (vs *FileShareService) ListFileShareTargets(shareID string, filters *models
 		}
 	}
 
-	resp, err := req.Invoke()
+	_, err := req.Invoke()
 	if err != nil {
-		if len(apiErr.Errors) > 0 {
-			apiErr.Errors[0].Status = resp.Status
-		}
 		return nil, err
 	}
 

common/vpcclient/vpcfilevolume/list_file_shares.go

@@ -65,11 +65,8 @@ func (vs *FileShareService) ListFileShares(limit int, start string, filters *mod
 		}
 	}
 
-	resp, err := req.Invoke()
+	_, err := req.Invoke()
 	if err != nil {
-		if len(apiErr.Errors) > 0 {
-			apiErr.Errors[0].Status = resp.Status
-		}
 		return nil, err
 	}
 

common/vpcclient/vpcfilevolume/list_security_groups.go

@@ -67,11 +67,8 @@ func (vs *FileShareService) ListSecurityGroups(limit int, start string, filters
 
 	ctxLogger.Info("Equivalent curl command", zap.Reflect("URL", req.URL()))
 
-	resp, err := req.Invoke()
+	_, err := req.Invoke()
 	if err != nil {
-		if len(apiErr.Errors) > 0 {
-			apiErr.Errors[0].Status = resp.Status
-		}
 		return nil, err
 	}