Support for norm of Diagonal

Author: Katharine Hyatt

src/blas/highlevel.jl

@@ -45,6 +45,7 @@ function LinearAlgebra.:(*)(
     dotu(n, x, stride(x, 1), y, stride(y, 1))
 end
 
+LinearAlgebra.norm(x::Diagonal{T, <:StridedROCVector{T}}, p::Real=2) where {T<:Union{Float16, ComplexF16, ROCBLASFloat}} = norm(x.diag, p)
 LinearAlgebra.norm(x::ROCArray{T}) where T <: ROCBLASFloat = nrm2(length(x), x, stride(x, 1))
 LinearAlgebra.BLAS.asum(x::ROCArray{T}) where T <: ROCBLASFloat = asum(length(x), x, stride(x, 1))
 

test/rocarray/blas.jl

@@ -58,6 +58,14 @@ end
 
         @test testf(reflect!, rand(T, m), rand(T, m), rand(real(T)), rand(real(T)))
         @test testf(reflect!, rand(T, m), rand(T, m), rand(real(T)), rand(T))
+
+        # norm of Diagonal
+        x = rand(T, m)
+        dDx = Diagonal(ROCArray(x))
+        Dx = Diagonal(x)
+        @test norm(dDx, 1)   ≈ norm(Dx, 1)
+        @test norm(dDx, 2)   ≈ norm(Dx, 2)
+        @test norm(dDx, Inf) ≈ norm(Dx, Inf)
     end
 end