Skip to content

[GTK4] Stop using gtk_widget_set_parent? #2821

@jonahgraham

Description

@jonahgraham

While working on #2819 I see that Button uses gtk_widget_set_parent:

However gtk_widget_set_parent is documented with this note:

This function is useful only when implementing subclasses of GtkWidget.

In gtk_button_set_child, which is the correct method for GtkButton to change parent/child relationship, it calls gtk_widget_set_parent here.

This means there is some stuff that gtk_button_set_child does that we are missing in SWT's implementation. However, I don't know if there are any user visible effects of using this method. I plan to return to this later, once #2819 is done.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

No status

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions