Fix crash in Messaging on Android when Terminate is called while tasks are still pending. (#739)

* Andriod ANR

When firebase::messaging::Terminate is called while there are still pending tasks left a null pointer exception is causing an ANR on Andriod.

FutureData is destroyed before calling util::Terminate which in turn will try to cancel all pending callbacks. This will call cancel() in JniResultCallback.java which will lock a mutex and callback into C++ using the JniResultCallback_nativeResult function. Depending on the task canceled it will call into different callbacks in messaging.cc and some of them as for example CompleteStringCallback are using FutureData which has already been destroyed. This will cause the thread to stop and the mutex in JniResultCallbak.java to remain locked. The next message that either completes or fails will now end up in a dead lock causing an ANR.

The proposed fix is to not destroy FutureData until after the tasks have been canceled.

* Updated readme

Author: TBarendt

messaging/src/android/cpp/messaging.cc

@@ -704,8 +704,8 @@ void Terminate() {
   g_firebase_messaging = nullptr;
   SetListener(nullptr);
   ReleaseClasses(env);
-  FutureData::Destroy();
   util::Terminate(env);
+  FutureData::Destroy();
 }
 
 // Start a service which will communicate with the Firebase Cloud Messaging

release_build_files/readme.md

@@ -572,6 +572,8 @@ code.
     -   Auth (Desktop): Fixed a crash in `error_code()` when a request
         is cancelled or times out.
         ([#737](https://github.com/firebase/firebase-cpp-sdk/issues/737))
+    -   Messaging (Android): Fixed crash during termination.
+        ([#739](https://github.com/firebase/firebase-cpp-sdk/pull/739))
 
 ### 8.7.0
 -   Changes