Throws an error when params in optimizer are not the same as that of module's in make_private

Summary: Compare nn.Module.parameters() with list of parameters from all param_groups of optimizer. If they are all not equal then raise error "Module parameters are different than optimizer Parameters"

Differential Revision: D37163873

fbshipit-source-id: a1d3302e1e7098129b6ae8f1eab52d335b62e20e

Author: Deepak Agrawal

opacus/privacy_engine.py

@@ -360,6 +360,9 @@ def make_private(
         if noise_generator and self.secure_mode:
             raise ValueError("Passing seed is prohibited in secure mode")
 
+        if list(module.parameters()) != sum([param_group['params'] for param_group in optimizer.param_groups], []):
+            raise ValueError("Module parameters are different than optimizer Parameters")
+
         distributed = isinstance(module, (DPDDP, DDP))
 
         module = self._prepare_model(