Add more typehints

Author: neildaniels

lib/Tmdb/Factory/AbstractFactory.php

@@ -167,7 +167,7 @@ protected function getHttpClient()
      * Create the account states
      *
      * @param array $data
-     * @return AbstractModel
+     * @return AccountStates
      */
     public function createAccountStates(array $data = [])
     {
@@ -190,7 +190,7 @@ public function createAccountStates(array $data = [])
      * Create result
      *
      * @param array $data
-     * @return AbstractModel
+     * @return Result
      */
     public function createResult(array $data = [])
     {

lib/Tmdb/Factory/AuthenticationFactory.php

@@ -16,6 +16,8 @@
 
 use DateTime;
 use RuntimeException;
+use Tmdb\Model\AbstractModel;
+use Tmdb\Model\Common\GenericCollection;
 use Tmdb\Token\Session\GuestSessionToken;
 use Tmdb\Token\Session\RequestToken;
 use Tmdb\Token\Session\SessionToken;
@@ -29,7 +31,7 @@ class AuthenticationFactory extends AbstractFactory
     /**
      * @param array $data
      *
-     * @return void
+     * @return AbstractModel
      * @throws RuntimeException
      */
     public function create(array $data = [])
@@ -44,7 +46,7 @@ public function create(array $data = [])
     /**
      * @param array $data
      *
-     * @return void
+     * @return GenericCollection
      * @throws RuntimeException
      */
     public function createCollection(array $data = [])
@@ -106,7 +108,7 @@ public function createSessionToken(array $data = [])
      * Create session token for guest
      *
      * @param array $data
-     * @return SessionToken
+     * @return GuestSessionToken
      */
     public function createGuestSessionToken(array $data = [])
     {

lib/Tmdb/Factory/GuestSessionFactory.php

@@ -14,6 +14,10 @@
 
 namespace Tmdb\Factory;
 
+use Tmdb\Exception\NotImplementedException;
+use Tmdb\Model\AbstractModel;
+use Tmdb\Model\Common\GenericCollection;
+
 /**
  * Currently a place-holder for future expansions
  *
@@ -25,18 +29,20 @@ class GuestSessionFactory extends AbstractFactory
     /**
      * {@inheritdoc}
      *
-     * @return void
+     * @throws NotImplementedException
      */
     public function create(array $data = [])
     {
+        throw new NotImplementedException('GuestSessionFactory does not implement create.');
     }
 
     /**
      * {@inheritdoc}
      *
-     * @return void
+     * @throws NotImplementedException
      */
     public function createCollection(array $data = [])
     {
+        throw new NotImplementedException('GuestSessionFactory does not implement createCollection.');
     }
 }

lib/Tmdb/HttpClient/HttpClient.php

@@ -75,9 +75,7 @@ public function __construct(
      * @param array $headers
      * @param null $body
      *
-     * @return array|string
-     *
-     * @psalm-return array<empty, empty>|string
+     * @return ResponseInterface
      */
     public function send(string $path, string $method, array $parameters = [], array $headers = [], $body = null)
     {

lib/Tmdb/Model/Account/ListItem.php

@@ -70,7 +70,7 @@ class ListItem extends AbstractModel
      */
     private $posterPath;
     /**
-     * @var PosterImage
+     * @var PosterImage|Image
      */
     private $posterImage;
 

lib/Tmdb/Model/Collection/Images.php

@@ -38,7 +38,7 @@ public function getImages()
      * Retrieve a image from the collection
      *
      * @param $id
-     * @return GenericCollection
+     * @return ?Image
      */
     public function getImage($id)
     {

lib/Tmdb/Model/Movie.php

@@ -195,7 +195,7 @@ class Movie extends AbstractModel
      */
     private $productionCountries;
     /**
-     * @var DateTime
+     * @var ?DateTime
      */
     private $releaseDate;
     /**
@@ -309,7 +309,7 @@ public function getBelongsToCollection()
     }
 
     /**
-     * @param null $belongsToCollection
+     * @param GenericCollection $belongsToCollection
      * @return self
      */
     public function setBelongsToCollection($belongsToCollection)

lib/Tmdb/Model/Query/Discover/DiscoverMoviesQuery.php

@@ -202,7 +202,7 @@ protected function getDate($year, $format = 'Y-m-d')
     }
 
     /**
-     * @return static
+     * @return self
      * @deprecated
      *
      */
@@ -227,7 +227,7 @@ public function primaryReleaseDateGte($year)
     }
 
     /**
-     * @return static
+     * @return self
      * @deprecated
      *
      */

lib/Tmdb/Repository/DiscoverRepository.php

@@ -17,6 +17,7 @@
 use Tmdb\Api\Discover;
 use Tmdb\Exception\NotImplementedException;
 use Tmdb\Exception\RuntimeException;
+use Tmdb\Factory\AbstractFactory;
 use Tmdb\Factory\FactoryInterface;
 use Tmdb\Factory\MovieFactory;
 use Tmdb\Factory\TvFactory;
@@ -102,7 +103,7 @@ public function getTvFactory()
     /**
      * Discover currently does not offer an factory
      *
-     * @return void
+     * @return AbstractFactory
      * @throws NotImplementedException
      */
     public function getFactory()

lib/Tmdb/Repository/MovieRepository.php

@@ -316,7 +316,7 @@ public function getLists($id, array $parameters = [], array $headers = []): Gene
      * @param $id
      * @param $parameters
      * @param $headers
-     * @return null|AbstractModel
+     * @return GenericCollection
      */
     public function getChanges($id, array $parameters = [], array $headers = [])
     {