-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[https://nvbugs/5515753][ci] Add NCCL_DEBUG=INFO flag to collect more… #8440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdded NCCL debug logging to Jenkins multi-GPU test environment. Removed a conditional test skip for tensor parallel size 4 in DeepSeek multi-GPU tests, allowing those configurations to execute. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/bot run --disable-fail-fast --extra-stage "DGX_H100-4_GPUs-PyTorch-DeepSeek-1, DGX_H100-4_GPUs-PyTorch-DeepSeek-2" |
|
PR_Github #21610 [ run ] triggered by Bot |
|
PR_Github #21610 [ run ] completed with state |
|
/bot run --disable-fail-fast --extra-stage "DGX_H100-4_GPUs-PyTorch-DeepSeek-1, DGX_H100-4_GPUs-PyTorch-DeepSeek-2" |
|
PR_Github #21626 [ run ] triggered by Bot |
|
PR_Github #21626 [ run ] completed with state |
|
/bot run --disable-fail-fast --stage-list "DGX_H100-4_GPUs-PyTorch-DeepSeek-1, DGX_H100-4_GPUs-PyTorch-DeepSeek-2" |
The initial CI failed with timeout on unittest/B200_PCIe-PyTorch-2/unittest/_torch/thop/parallel/test_moe.py::TestMoeFp4::test_autotune[RoutingDSv3-384-1024-1024] in the |
|
PR_Github #21716 [ run ] triggered by Bot. Commit: |
|
PR_Github #21716 [ run ] completed with state |
Got Pod failed (Reason: Terminated, Message: Pod was terminated in response to imminent node shutdown.) Need to rerun the pipeline. |
|
/bot run --disable-fail-fast --extra-stage "DGX_H100-4_GPUs-PyTorch-DeepSeek-1, DGX_H100-4_GPUs-PyTorch-DeepSeek-2" |
|
PR_Github #21729 [ run ] triggered by Bot. Commit: |
|
PR_Github #21729 [ run ] completed with state |
More single node test failures with TestMoeFp4, added more waives and restart the CI. |
|
/bot run --disable-fail-fast --extra-stage "DGX_H100-4_GPUs-PyTorch-DeepSeek-1, DGX_H100-4_GPUs-PyTorch-DeepSeek-2" |
|
PR_Github #21755 [ run ] triggered by Bot. Commit: |
|
PR_Github #21755 [ run ] completed with state |
GB300 node request failed. x86 single and multi node tests all passed. |
a81d670 to
9b230f8
Compare
|
/bot run --disable-fail-fast --extra-stage "DGX_H100-4_GPUs-PyTorch-DeepSeek-1, DGX_H100-4_GPUs-PyTorch-DeepSeek-2" |
|
PR_Github #21819 [ run ] triggered by Bot. Commit: |
|
PR_Github #21819 [ run ] completed with state |
… info with CI failure. Hard to reproduce the error locally Signed-off-by: Simeng Liu <simengl@nvidia.com>
…tune[RoutingDSv3-384-1024-1024] failed with timeout. Signed-off-by: Simeng Liu <simengl@nvidia.com>
…no_autotune entirely for known timeout issues. Signed-off-by: Simeng Liu <simengl@nvidia.com>
Signed-off-by: Simeng Liu <simengl@nvidia.com>
9b230f8 to
ab16bed
Compare
Got a new failure on multi-GPU test that unrelated to this PR. Added a new commit to waive it and filed an nvbug. |
|
@shaharmor98 May I get a CI skip on this PR? |
|
/bot run --disable-fail-fast --extra-stage "DGX_H100-4_GPUs-PyTorch-DeepSeek-1, DGX_H100-4_GPUs-PyTorch-DeepSeek-2" |
|
PR_Github #21922 [ run ] triggered by Bot. Commit: |
|
New CI pipeline failed to schedule slurm job on DGX_B200-4_GPU nodes. |
|
PR_Github #21922 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #22072 [ run ] triggered by Bot. Commit: |
|
PR_Github #22072 [ run ] completed with state |
|
@NVIDIA/trt-llm-release-branch-approval Hi team, can i get reviews for this PR? It's needed for the merge. Thanks! |
… info with CI failure. (NVIDIA#8440) Signed-off-by: Simeng Liu <simengl@nvidia.com>
… info with CI failure. (NVIDIA#8440) Signed-off-by: Simeng Liu <simengl@nvidia.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
… info with CI failure. (NVIDIA#8440) Signed-off-by: Simeng Liu <simengl@nvidia.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
… info with CI failure. (NVIDIA#8440) Signed-off-by: Simeng Liu <simengl@nvidia.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
… info with CI failure. (NVIDIA#8440) Signed-off-by: Simeng Liu <simengl@nvidia.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
… info with CI failure. (NVIDIA#8440) Signed-off-by: Simeng Liu <simengl@nvidia.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
… info with CI failure. (NVIDIA#8440) Signed-off-by: Simeng Liu <simengl@nvidia.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
… info with CI failure. (NVIDIA#8440) Signed-off-by: Simeng Liu <simengl@nvidia.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
… info with CI failure. (NVIDIA#8440) Signed-off-by: Simeng Liu <simengl@nvidia.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
… info with CI failure. (NVIDIA#8440) Signed-off-by: Simeng Liu <simengl@nvidia.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
… info with CI failure. (NVIDIA#8440) Signed-off-by: Simeng Liu <simengl@nvidia.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com> Signed-off-by: Mike Iovine <miovine@nvidia.com>
… info with CI failure. (#8440) Signed-off-by: Simeng Liu <simengl@nvidia.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com> Signed-off-by: Mike Iovine <miovine@nvidia.com>
… info with CI failure. Hard to reproduce the error locally
Summary by CodeRabbit
Tests
Chores
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.