Skip to content

Conversation

@QiJune
Copy link
Collaborator

@QiJune QiJune commented Oct 20, 2025

Summary by CodeRabbit

  • Chores
    • Updated test infrastructure configurations for H100 PCIe hardware to expand PyTorch test coverage across multiple configurations and optimize testing resource allocation.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
@QiJune QiJune requested review from a team as code owners October 20, 2025 06:07
@QiJune QiJune requested review from ruodil and xinhe-nv October 20, 2025 06:07
@QiJune
Copy link
Collaborator Author

QiJune commented Oct 20, 2025

/bot run --gpu-type "H100_PCIe"

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 20, 2025

📝 Walkthrough

Walkthrough

Modified H100 PCIe test matrix in Jenkins configuration by expanding PyTorch test coverage to four split configurations, replacing CPP and TensorRT multi-split entries with single-split equivalents, and maintaining existing PyTorch-Ray configuration.

Changes

Cohort / File(s) Summary
H100 PCIe Test Matrix Configuration
jenkins/L0_Test.groovy
Added four new H100 PCIe-PyTorch configurations (1–4) with split count 4. Replaced two-split CPP and TensorRT entries with single-split variants. Retained PyTorch-Ray-1 entry.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description provided is largely incomplete. While the title follows the correct format, the required "Description" and "Test Coverage" sections contain only template comments with no actual content filled in. The author checked the final PR Checklist box but did not complete the substantive sections explaining what changes were made, why they were made, and which tests validate these changes. The PR description currently lacks the information necessary for reviewers to understand the rationale and testing approach for the H100 stage rebalancing. The author should fill in the "Description" section explaining why the H100 stages are being rebalanced and the impact of these changes, and complete the "Test Coverage" section describing which tests validate the new PyTorch configurations and updated CPP/TensorRT entries. These sections are required by the repository's PR template and are essential for reviewers to evaluate the changes properly.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[None][ci] rebalance H100 stages" follows the repository's required format with a [ticket][type] structure and clearly identifies the main change: rebalancing H100 test stages in the CI infrastructure. The title is specific and directly reflects the changeset's primary objective of adjusting the H100 PCIe test matrix by expanding PyTorch configurations and updating CPP/TensorRT entries. The term "rebalance" accurately describes the modification to the test matrix entries.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
jenkins/L0_Test.groovy (1)

2453-2456: H100 PyTorch: moved to 4-way split — verify shard density to avoid empty-shard hard fails.

Looks good and keeps the expected stage-config syntax. Please confirm l0_h100 has enough tests so each of 4 shards gets ≥1 test; otherwise runLLMTestlistOnPlatformImpl will error when both regular/isolate counts are zero for a shard.

Optional guard to treat empty shards as “skipped” instead of failing:

@@
-        if (noRegularTests && noIsolateTests) {
-            error "No tests were executed for stage ${stageName}, please check the test list and test-db rendering result."
-        }
+        if (noRegularTests && noIsolateTests) {
+            echo "Shard produced no tests for ${stageName}; marking as skipped."
+            sh """
+                echo '<?xml version="1.0" encoding="UTF-8"?>' > ${stageName}/results.xml
+                echo '<testsuites><testsuite name="${stageName}" errors="0" failures="0" skipped="0" tests="0" time="0.0"/></testsuites>' >> ${stageName}/results.xml
+            """
+            return
+        }
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d05079b and a397ee5.

📒 Files selected for processing (1)
  • jenkins/L0_Test.groovy (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
jenkins/L0_Test.groovy (1)

2458-2459: H100 CPP/TensorRT collapsed to single split — check runtime/queue impact.

Consolidation is fine; just verify stage wall time remains acceptable and doesn’t bottleneck H100 capacity. If runtime regresses, consider restoring minimal splitting (e.g., 1/2) or scoping the YAML to a lighter subset.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21864 [ run ] triggered by Bot. Commit: a397ee5

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21864 [ run ] completed with state SUCCESS. Commit: a397ee5
/LLM/main/L0_MergeRequest_PR pipeline #16482 (Partly Tested) completed with status: 'FAILURE'

@QiJune
Copy link
Collaborator Author

QiJune commented Oct 20, 2025

/bot run --gpu-type "H100_PCIe"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21901 [ run ] triggered by Bot. Commit: bf5a79f

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21901 [ run ] completed with state SUCCESS. Commit: bf5a79f
/LLM/main/L0_MergeRequest_PR pipeline #16511 (Partly Tested) completed with status: 'SUCCESS'

@QiJune QiJune requested a review from chzblych October 21, 2025 00:28
@QiJune
Copy link
Collaborator Author

QiJune commented Oct 21, 2025

/bot skip --comment "all H100 stages passed"

@QiJune QiJune enabled auto-merge (squash) October 21, 2025 05:23
@tensorrt-cicd
Copy link
Collaborator

PR_Github #22005 [ skip ] triggered by Bot. Commit: bf5a79f

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22005 [ skip ] completed with state SUCCESS. Commit: bf5a79f
Skipping testing for commit bf5a79f

@QiJune QiJune merged commit 0acd10e into NVIDIA:main Oct 21, 2025
5 checks passed
govind-ramnarayan pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Oct 21, 2025
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request Oct 24, 2025
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 1, 2025
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants