[None][fix] the api_stability unify default values of None and inspect._empty

[Superjomn]

Summary by CodeRabbit

• Tests
  • Improved parameter snapshot normalization in API stability testing to ensure consistent default value representation during validation checks.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[Superjomn]

/bot run

[coderabbitai]

📝 Walkthrough

Walkthrough

A __post_init__ method is added to the ParamSnapshot dataclass to normalize the default field by converting inspect._empty values to None, ensuring consistent default representation for instances created from inspect.Parameter objects.

Changes

Cohort / File(s)	Change Summary
ParamSnapshot post-initialization normalization tests/unittest/api_stability/api_stability_core.py	Added __post_init__ method to normalize the default field: converts inspect._empty to None for consistent representation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description is incomplete and does not follow the repository's template requirements. While the description includes the full template structure, all critical sections remain unfilled: the Description section contains only an HTML comment placeholder with no explanation of the issue or solution, the Test Coverage section is empty with no identification of relevant tests, and the PR Checklist contains only a generic checkbox with no specific context. The description provides no substantive information about why this change was made, what problem it solves, or what tests validate the fix, making it impossible to understand the rationale and validation for this API stability modification.	The author should update the PR description by filling in the Description section with an explanation of the issue (why inspect._empty and None need to be unified) and the solution approach. The Test Coverage section should explicitly list which tests in tests/unittest/api_stability/ validate this post_init normalization logic. This will ensure reviewers have the necessary context to evaluate the change and confirm sufficient test coverage exists for the fix.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The PR title "[None][fix] the api_stability unify default values of None and inspect._empty" follows the required template format with a proper ticket identifier ([None]) and type ([fix]). The summary clearly and specifically describes the main change: normalizing API stability by unifying how default values are handled when converting between None and inspect._empty. This directly aligns with the code change documented in the raw_summary, which adds a post_init method to normalize the ParamSnapshot dataclass's default field. The title is concise, avoids generic language, and a team member reviewing history would understand this is a targeted fix for default value consistency in the API stability module.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

tests/unittest/api_stability/api_stability_core.py (2)

127-128: Dead code: condition can never be true after normalization.

After the __post_init__ method (lines 82-85) normalizes inspect._empty to None, self.default can never be inspect._empty, making this check always false.

Consider removing these lines or updating the logic to be consistent with the normalization policy:

-    if d['default'] == inspect._empty:
-        d['default'] = "inspect._empty"

---

104-105: Circular logic: assignment immediately undone by normalization.

Setting default = inspect._empty when param.default is None is immediately reversed by the __post_init__ method (lines 82-85), which converts inspect._empty back to None.

Consider simplifying this to directly use None:

     if param.default is None:
-        default = inspect._empty
+        default = None

This makes the logic consistent with the normalization policy and removes the unnecessary conversion.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d05079b and 25bbfd4.

📒 Files selected for processing (1)

• tests/unittest/api_stability/api_stability_core.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

• tests/unittest/api_stability/api_stability_core.py

**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

• tests/unittest/api_stability/api_stability_core.py

**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

• tests/unittest/api_stability/api_stability_core.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Pre-commit Check

[Superjomn]

/bot run

[tensorrt-cicd]

PR_Github #21878 [ run ] triggered by Bot. Commit: 2dce6ac

[tensorrt-cicd]

PR_Github #21878 [ run ] completed with state SUCCESS. Commit: 2dce6ac
/LLM/main/L0_MergeRequest_PR pipeline #16492 completed with status: 'FAILURE'

[Superjomn]

/bot run

[tensorrt-cicd]

PR_Github #21954 [ run ] triggered by Bot. Commit: a6e458a

[tensorrt-cicd]

PR_Github #21954 [ run ] completed with state SUCCESS. Commit: a6e458a
/LLM/main/L0_MergeRequest_PR pipeline #16551 completed with status: 'FAILURE'

[Superjomn]

/bot run

[tensorrt-cicd]

PR_Github #21987 [ run ] triggered by Bot. Commit: a6e458a

[tensorrt-cicd]

PR_Github #21987 [ run ] completed with state SUCCESS. Commit: a6e458a
/LLM/main/L0_MergeRequest_PR pipeline #16578 completed with status: 'SUCCESS'

[QiJune]

LGTM