Skip to content

Conversation

@EmmaQiaoCh
Copy link
Collaborator

@EmmaQiaoCh EmmaQiaoCh commented Oct 21, 2025

Summary by CodeRabbit

  • Tests
    • Updated test skip configuration for specific integration tests.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: qqiao <qqiao@nvidia.com>
@EmmaQiaoCh
Copy link
Collaborator Author

/bot run --stage-list "A10-PyTorch-1, A100X-PyTorch-1, H100_PCIe-PyTorch-Ray-1"

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 21, 2025

📝 Walkthrough

Walkthrough

This PR adds three new SKIP entries to the test waiver list for RPC and LLM-related tests that are failing. No functional code changes are made; this is a configuration update to temporarily exclude specific test cases from execution.

Changes

Cohort / File(s) Summary
Test Waiver List Updates
tests/integration/test_lists/waives.txt
Appends three new SKIP entries for RPC and LLM-related tests: unittest/executor/test_rpc.py::test_rpc_without_response_performance, unittest/executor/test_rpc_worker.py::TestRpcWorkerTP1::test_fetch_stats_loop_async, and unittest/llmapi/test_llm_pytorch.py::test_llm_capture_request_error

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • ZhanruiSunCh
  • yiqingy0
  • niukuo
  • chzblych

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description is largely incomplete and does not meet the repository's template requirements. While the PR title follows the correct format ([None][infra] Waive failed tests for main 10/21), the Description section and Test Coverage section are entirely empty, containing only template placeholders asking the author to fill in information. The Description section should explain what issue is being addressed and the solution provided, but no such explanation is included. The Test Coverage section should list relevant tests, but no tests are documented. Only one item in the PR Checklist is marked, and the description fails to provide the necessary context about which tests are being waived and why this change is needed. The author should fill in the Description section with an explanation of why these three test waivers are needed and what tests are affected (referencing the three SKIP entries being added to waives.txt). The Test Coverage section should document the specific tests being waived: unittest/executor/test_rpc.py::test_rpc_without_response_performance, unittest/executor/test_rpc_worker.py::TestRpcWorkerTP1::test_fetch_stats_loop_async, and unittest/llmapi/test_llm_pytorch.py::test_llm_capture_request_error. Additionally, the author should explicitly verify and document each item in the PR Checklist that applies to this infrastructure change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title [None][infra] Waive failed tests for main 10/21 follows the required template format correctly with the [None] ticket identifier, [infra] type classification, and a clear summary. The title accurately reflects the main change in the pull request, which adds three SKIP entries to the waiver list for RPC and LLM-related tests. It is concise, specific, and clearly communicates the purpose of the changeset to someone reviewing the commit history, without being overly verbose or generic.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22020 [ run ] triggered by Bot. Commit: 58a8fcb

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22020 [ run ] completed with state FAILURE. Commit: 58a8fcb
/LLM/main/L0_MergeRequest_PR pipeline #16601 (Partly Tested) completed with status: 'FAILURE'

Signed-off-by: qqiao <qqiao@nvidia.com>
@EmmaQiaoCh
Copy link
Collaborator Author

/bot run --stage-list "A10-PyTorch-1, A100X-PyTorch-1, H100_PCIe-PyTorch-Ray-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22033 [ run ] triggered by Bot. Commit: 70a9296

Copy link
Collaborator

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmmaQiaoCh
Copy link
Collaborator Author

/bot skip --comment "Waive failed cases for main"

@EmmaQiaoCh EmmaQiaoCh enabled auto-merge (squash) October 21, 2025 09:52
@EmmaQiaoCh EmmaQiaoCh requested a review from chzblych October 21, 2025 09:55
@tensorrt-cicd
Copy link
Collaborator

PR_Github #22033 [ run ] completed with state SUCCESS. Commit: 70a9296
/LLM/main/L0_MergeRequest_PR pipeline #16612 (Partly Tested) completed with status: 'SUCCESS'

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22043 [ skip ] triggered by Bot. Commit: 70a9296

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22043 [ skip ] completed with state SUCCESS. Commit: 70a9296
Skipping testing for commit 70a9296

@EmmaQiaoCh EmmaQiaoCh merged commit 653aa6b into NVIDIA:main Oct 21, 2025
6 of 7 checks passed
govind-ramnarayan pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Oct 21, 2025
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request Oct 24, 2025
Signed-off-by: qqiao <qqiao@nvidia.com>
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants