Skip to content

Conversation

@Shixiaowei02
Copy link
Collaborator

@Shixiaowei02 Shixiaowei02 commented Oct 21, 2025

Summary by CodeRabbit

  • Tests
    • Updated test suite configurations to manage test execution parameters.

Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
@Shixiaowei02
Copy link
Collaborator Author

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 21, 2025

📝 Walkthrough

Walkthrough

The pull request updates the test waives configuration file by removing a skip entry for a disaggregated test and adding a skip entry for a Triton server test. The modification updates which tests are excluded from execution.

Changes

Cohort / File(s) Summary
Test waives configuration
tests/integration/test_lists/waives.txt
Removed skip entry for disaggregated/test_disaggregated.py::test_disaggregated_diff_max_tokens[TinyLlama-1.1B-Chat-v1.0] and added skip entry for triton_server/test_triton.py::test_python_bls_unit_tests[python-bls-unit-tests]

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request lacks any substantive description from the author. While the PR title appears to follow the required format ([https://nvbugs/5451272][fix] unwaive the test), the PR body contains no actual description, test coverage information, or completed checklist items. The template structure is present in the repository guidelines, but the author has not filled in any of the required sections, leaving reviewers without context about why the changes were made or what testing was performed to validate them. Based on the raw summary, the changes involve modifying waives.txt by removing and adding test entries, but this information should be clearly articulated in the PR description itself. The author must add a proper PR description that includes: (1) an explanation of the changes and their purpose, (2) a test coverage section detailing which tests validate the changes, and (3) a completed PR checklist indicating that the coding guidelines, test coverage, dependencies, and documentation requirements have been reviewed. At minimum, the description should explain what test entries were modified in waives.txt and the rationale for these changes related to NVBugs 5451272.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "[https://nvbugs/5451272][fix] unwaive the test" follows the required template format with a valid NVBugs ID, the [fix] type indicator, and a clear summary. The title directly aligns with the changeset, which removes one test entry and adds another in a waives.txt file, effectively representing the action of "unwaiving" tests. The title is concise, specific, and clearly communicates the primary change to someone reviewing the git history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22054 [ run ] triggered by Bot. Commit: 7488dca

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22054 [ run ] completed with state SUCCESS. Commit: 7488dca
/LLM/main/L0_MergeRequest_PR pipeline #16629 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@Shixiaowei02 Shixiaowei02 requested a review from chuangz0 October 22, 2025 06:28
@Shixiaowei02 Shixiaowei02 enabled auto-merge (squash) October 22, 2025 06:28
@Shixiaowei02 Shixiaowei02 merged commit 7794063 into NVIDIA:main Oct 22, 2025
8 of 9 checks passed
@Shixiaowei02 Shixiaowei02 deleted the user/xiaoweis/unwaive-test branch October 22, 2025 06:28
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request Oct 24, 2025
Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 1, 2025
Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants