Skip to content

Conversation

@ixlmar
Copy link
Collaborator

@ixlmar ixlmar commented Oct 21, 2025

Description

This change ensures that stubs for all submodules of tensorrt_llm.bindings are generated (see https://nanobind.readthedocs.io/en/latest/typing.html#recursive-stub-generation).

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

  • Chores
    • Updated stub generation process for Linux build environments.
    • Improved build cache cleanup when switching binding types, ensuring more comprehensive directory removal for better build consistency.

@ixlmar ixlmar requested a review from Linda-Stadter October 21, 2025 14:15
@ixlmar
Copy link
Collaborator Author

ixlmar commented Oct 21, 2025

/bot run --skip-test

@ixlmar ixlmar changed the title [None][Fix] generate nanobind stubs for submodules [None][fix] generate nanobind stubs for submodules Oct 21, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 21, 2025

📝 Walkthrough

Walkthrough

The build script modifications include adding the -r flag to nanobind stubgen invocation for recursive stub generation and expanding cache cleanup to delete the entire bindings directory instead of just a single file when switching binding types.

Changes

Cohort / File(s) Summary
Build script stub and cache handling
scripts/build_wheel.py
Added -r flag to nanobind.stubgen invocation for recursive stub generation; changed cache cleanup to delete entire bindings directory and related pybind directory instead of single bindings.pyi file when switching binding types

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description includes a Description section that adequately explains the change and references the relevant nanobind documentation for recursive stub generation. However, the Test Coverage section is entirely empty with no information provided about what tests validate these changes, despite the template explicitly requesting this information. The PR Checklist is present but incomplete, with most items unchecked. While the core description is present and sufficient, the complete absence of test coverage information represents a significant gap in the required template structure. The Test Coverage section must be completed by providing information about what tests safeguard these build script changes, or explicitly explaining why test coverage validation does not apply to this particular modification. This ensures the PR follows the repository's documentation standards and helps reviewers understand the testing scope.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "[None][fix] generate nanobind stubs for submodules" is directly aligned with the main objective and the primary code change. The raw summary shows that the key modification is adding the -r flag to the nanobind.stubgen invocation (nanobind.stubgen -m bindings -r -O .), which enables recursive stub generation for submodules. The title accurately captures this intent and describes the main change in clear, specific terms without vague language. The title is concise and would allow a teammate scanning the repository history to immediately understand that the change is about enabling nanobind stub generation for submodules.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22063 [ run ] triggered by Bot. Commit: 6d89c0f

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22063 [ run ] completed with state SUCCESS. Commit: 6d89c0f
/LLM/main/L0_MergeRequest_PR pipeline #16636 (Partly Tested) completed with status: 'SUCCESS'

@ixlmar
Copy link
Collaborator Author

ixlmar commented Oct 22, 2025

/bot skip --comment "Only build script changes, passed sanity checks"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22141 [ skip ] triggered by Bot. Commit: 6d89c0f

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22141 [ skip ] completed with state SUCCESS. Commit: 6d89c0f
Skipping testing for commit 6d89c0f

Signed-off-by: ixlmar <206748156+ixlmar@users.noreply.github.com>
@ixlmar ixlmar force-pushed the fix/nanobind-stubs branch from 6d89c0f to 93fb76c Compare October 22, 2025 07:55
@ixlmar ixlmar requested a review from a team as a code owner October 22, 2025 07:55
@ixlmar
Copy link
Collaborator Author

ixlmar commented Oct 22, 2025

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22150 [ run ] triggered by Bot. Commit: 93fb76c

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22150 [ run ] completed with state SUCCESS. Commit: 93fb76c
/LLM/main/L0_MergeRequest_PR pipeline #16703 (Partly Tested) completed with status: 'SUCCESS'

@ixlmar
Copy link
Collaborator Author

ixlmar commented Oct 22, 2025

/bot skip --comment "Only build script changes, passed sanity checks"

@ixlmar ixlmar enabled auto-merge (squash) October 22, 2025 10:01
@ixlmar ixlmar disabled auto-merge October 22, 2025 10:01
@ixlmar ixlmar enabled auto-merge (squash) October 22, 2025 10:01
@tensorrt-cicd
Copy link
Collaborator

PR_Github #22173 [ skip ] triggered by Bot. Commit: 93fb76c

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22173 [ skip ] completed with state SUCCESS. Commit: 93fb76c
Skipping testing for commit 93fb76c

@ixlmar ixlmar merged commit 40a9c61 into NVIDIA:main Oct 22, 2025
5 checks passed
@ixlmar ixlmar deleted the fix/nanobind-stubs branch October 22, 2025 10:26
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request Oct 24, 2025
Signed-off-by: ixlmar <206748156+ixlmar@users.noreply.github.com>
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 1, 2025
Signed-off-by: ixlmar <206748156+ixlmar@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
Signed-off-by: ixlmar <206748156+ixlmar@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
Signed-off-by: ixlmar <206748156+ixlmar@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
Signed-off-by: ixlmar <206748156+ixlmar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants