fix(shared): import adequate FacetHit types for v4 and v5 search client #1280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cafc98c:
|
Haroenv
approved these changes
Oct 15, 2024
| /** @ts-ignore */ | ||
| v4: ClientSearch.FacetHit; | ||
| /** @ts-ignore */ | ||
| v5: AlgoliaSearch.FacetHits; |
Contributor
There was a problem hiding this comment.
FacetHit_s_ is a singular hit?
Member
Author
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes how
FacetHitis imported by conditionally returning the proper exported name, as algolia search v5 changed this toFacetHits.See Slack convo for more information.
Result
Projects that depend on autocomplete and which use algoliasearch@5 can now successfully build.