-
Notifications
You must be signed in to change notification settings - Fork 862
[EuiDataGrid] Enable row background color on hover for stripes={true}
#8983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
with changes from elastic/eui#8983
|
@JoseLuisGJ for awareness, just in case there's any work to do related to this, in the current code/design parity effort 👀 |
|
|
||
| buttonGroupFocusColor: SEMANTIC_COLORS.plainLight, | ||
|
|
||
| dataGridRowStripesBackgroundHover: SEMANTIC_COLORS.shade130, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Where was this color defined? The design specs states shade-15 but I don't see any specs for dark mode 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, it's indeed missing from the spec so I "made it up" deriving it from other light/dark pairs, so it needs validation from design (I was expecting this to come up during testing in Kibana, to adjust if needed, but both Kate and Laura are on PTO)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oki, yeah then let's wait for @ek-so to confirm or provide required specs once she's back 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you both! 130 is the correct color.
💚 Build SucceededHistory
cc @acstll |
💚 Build Succeeded
History
cc @acstll |
- `@elastic/eui`: `v106.4.0` ⏩ `v106.5.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ## [`v106.5.0`](https://github.com/elastic/eui/releases/v106.5.0) - Added an optional `offset` prop to `EuiToolTip` to allow customizing the distance (in pixels) between the tooltip and its anchor. ([#8988](elastic/eui#8988)) - Updated `EuiDataGrid` hover styles when `stripes={true}` to ensure a visible background color change on hover ([#8983](elastic/eui#8983)) **Bug fixes** - Fixed a 1ms time shift on `EuiSuperDatePicker` when using the quick select time window steps ([#8985](elastic/eui#8985)) - Fixed a visual issue in `EuiSuperDatePicker` with `isQuickSelectOnly` enabled, where delimiter padding caused an unexpected empty container ([#8985](elastic/eui#8985)) **Accessibility** - Changed the close button position in `EuiModal` to allow for the modal title to be perceivable first ([#8954](elastic/eui#8954)) - Added screen reader hint text on `EuiModal` to indicate closing behavior ([#8954](elastic/eui#8954)) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
- `@elastic/eui`: `v106.4.0` ⏩ `v106.5.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ## [`v106.5.0`](https://github.com/elastic/eui/releases/v106.5.0) - Added an optional `offset` prop to `EuiToolTip` to allow customizing the distance (in pixels) between the tooltip and its anchor. ([elastic#8988](elastic/eui#8988)) - Updated `EuiDataGrid` hover styles when `stripes={true}` to ensure a visible background color change on hover ([elastic#8983](elastic/eui#8983)) **Bug fixes** - Fixed a 1ms time shift on `EuiSuperDatePicker` when using the quick select time window steps ([elastic#8985](elastic/eui#8985)) - Fixed a visual issue in `EuiSuperDatePicker` with `isQuickSelectOnly` enabled, where delimiter padding caused an unexpected empty container ([elastic#8985](elastic/eui#8985)) **Accessibility** - Changed the close button position in `EuiModal` to allow for the modal title to be perceivable first ([elastic#8954](elastic/eui#8954)) - Added screen reader hint text on `EuiModal` to indicate closing behavior ([elastic#8954](elastic/eui#8954)) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
- `@elastic/eui`: `v106.5.0` ⏩ `v106.6.0` - `@elastic/eui-theme-borealis`: `v3.3.2` ⏩ `v3.4.0` - `@elastic/eslint-plugin-eui`: `v2.3.0` ⏩ `v2.4.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ### `@elastic/eui` #### [`v106.6.0`](https://github.com/elastic/eui/releases/v106.6.0) **Accessibility** - Removed focus state styles for `iconOnClick` on `EuiBadge` to improve color contrast in dark mode ([#9004](elastic/eui#9004)) ### `@elastic/eui-theme-borealis` #### [`v3.4.0`](https://www.npmjs.com/package/@elastic/eui-theme-borealis/v/3.4.0) - Updated values for component tokens ([#8983](elastic/eui#8983)) - `dataGridRowStripesBackgroundHover` - `dataGridRowStripesBackgroundStripedHover` - `dataGridRowStripesBackgroundSelectHover` - `dataGridRowStripesBackgroundHover` - `dataGridRowStripesBackgroundStripedHover` ### `@elastic/eslint-plugin-eui` #### [`v2.4.0`](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.4.0) - Added new `callout-announce-on-mount` rule. ([#9005](elastic/eui#9005)) - Added new `no-unnamed-interactive-element` rule. ([#8973](elastic/eui#8973))
- `@elastic/eui`: `v106.4.0` ⏩ `v106.5.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ## [`v106.5.0`](https://github.com/elastic/eui/releases/v106.5.0) - Added an optional `offset` prop to `EuiToolTip` to allow customizing the distance (in pixels) between the tooltip and its anchor. ([elastic#8988](elastic/eui#8988)) - Updated `EuiDataGrid` hover styles when `stripes={true}` to ensure a visible background color change on hover ([elastic#8983](elastic/eui#8983)) **Bug fixes** - Fixed a 1ms time shift on `EuiSuperDatePicker` when using the quick select time window steps ([elastic#8985](elastic/eui#8985)) - Fixed a visual issue in `EuiSuperDatePicker` with `isQuickSelectOnly` enabled, where delimiter padding caused an unexpected empty container ([elastic#8985](elastic/eui#8985)) **Accessibility** - Changed the close button position in `EuiModal` to allow for the modal title to be perceivable first ([elastic#8954](elastic/eui#8954)) - Added screen reader hint text on `EuiModal` to indicate closing behavior ([elastic#8954](elastic/eui#8954)) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
- `@elastic/eui`: `v106.5.0` ⏩ `v106.6.0` - `@elastic/eui-theme-borealis`: `v3.3.2` ⏩ `v3.4.0` - `@elastic/eslint-plugin-eui`: `v2.3.0` ⏩ `v2.4.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ### `@elastic/eui` #### [`v106.6.0`](https://github.com/elastic/eui/releases/v106.6.0) **Accessibility** - Removed focus state styles for `iconOnClick` on `EuiBadge` to improve color contrast in dark mode ([elastic#9004](elastic/eui#9004)) ### `@elastic/eui-theme-borealis` #### [`v3.4.0`](https://www.npmjs.com/package/@elastic/eui-theme-borealis/v/3.4.0) - Updated values for component tokens ([elastic#8983](elastic/eui#8983)) - `dataGridRowStripesBackgroundHover` - `dataGridRowStripesBackgroundStripedHover` - `dataGridRowStripesBackgroundSelectHover` - `dataGridRowStripesBackgroundHover` - `dataGridRowStripesBackgroundStripedHover` ### `@elastic/eslint-plugin-eui` #### [`v2.4.0`](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.4.0) - Added new `callout-announce-on-mount` rule. ([elastic#9005](elastic/eui#9005)) - Added new `no-unnamed-interactive-element` rule. ([elastic#8973](elastic/eui#8973))
- `@elastic/eui`: `v106.4.0` ⏩ `v106.5.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ## [`v106.5.0`](https://github.com/elastic/eui/releases/v106.5.0) - Added an optional `offset` prop to `EuiToolTip` to allow customizing the distance (in pixels) between the tooltip and its anchor. ([#8988](elastic/eui#8988)) - Updated `EuiDataGrid` hover styles when `stripes={true}` to ensure a visible background color change on hover ([#8983](elastic/eui#8983)) **Bug fixes** - Fixed a 1ms time shift on `EuiSuperDatePicker` when using the quick select time window steps ([#8985](elastic/eui#8985)) - Fixed a visual issue in `EuiSuperDatePicker` with `isQuickSelectOnly` enabled, where delimiter padding caused an unexpected empty container ([#8985](elastic/eui#8985)) **Accessibility** - Changed the close button position in `EuiModal` to allow for the modal title to be perceivable first ([#8954](elastic/eui#8954)) - Added screen reader hint text on `EuiModal` to indicate closing behavior ([#8954](elastic/eui#8954)) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
- `@elastic/eui`: `v106.5.0` ⏩ `v106.6.0` - `@elastic/eui-theme-borealis`: `v3.3.2` ⏩ `v3.4.0` - `@elastic/eslint-plugin-eui`: `v2.3.0` ⏩ `v2.4.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ### `@elastic/eui` #### [`v106.6.0`](https://github.com/elastic/eui/releases/v106.6.0) **Accessibility** - Removed focus state styles for `iconOnClick` on `EuiBadge` to improve color contrast in dark mode ([#9004](elastic/eui#9004)) ### `@elastic/eui-theme-borealis` #### [`v3.4.0`](https://www.npmjs.com/package/@elastic/eui-theme-borealis/v/3.4.0) - Updated values for component tokens ([#8983](elastic/eui#8983)) - `dataGridRowStripesBackgroundHover` - `dataGridRowStripesBackgroundStripedHover` - `dataGridRowStripesBackgroundSelectHover` - `dataGridRowStripesBackgroundHover` - `dataGridRowStripesBackgroundStripedHover` ### `@elastic/eslint-plugin-eui` #### [`v2.4.0`](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.4.0) - Added new `callout-announce-on-mount` rule. ([#9005](elastic/eui#9005)) - Added new `no-unnamed-interactive-element` rule. ([#8973](elastic/eui#8973))
- `@elastic/eui`: `v106.5.0` ⏩ `v106.6.0` - `@elastic/eui-theme-borealis`: `v3.3.2` ⏩ `v3.4.0` - `@elastic/eslint-plugin-eui`: `v2.3.0` ⏩ `v2.4.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ### `@elastic/eui` #### [`v106.6.0`](https://github.com/elastic/eui/releases/v106.6.0) **Accessibility** - Removed focus state styles for `iconOnClick` on `EuiBadge` to improve color contrast in dark mode ([elastic#9004](elastic/eui#9004)) ### `@elastic/eui-theme-borealis` #### [`v3.4.0`](https://www.npmjs.com/package/@elastic/eui-theme-borealis/v/3.4.0) - Updated values for component tokens ([elastic#8983](elastic/eui#8983)) - `dataGridRowStripesBackgroundHover` - `dataGridRowStripesBackgroundStripedHover` - `dataGridRowStripesBackgroundSelectHover` - `dataGridRowStripesBackgroundHover` - `dataGridRowStripesBackgroundStripedHover` ### `@elastic/eslint-plugin-eui` #### [`v2.4.0`](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.4.0) - Added new `callout-announce-on-mount` rule. ([elastic#9005](elastic/eui#9005)) - Added new `no-unnamed-interactive-element` rule. ([elastic#8973](elastic/eui#8973))
Summary
This PR adds a visual change to EuiDataGrid related to the background color of rows on hover, specifically when using stripes (
stripesprop equalstrue).The original design spec within the Visual Refresh effort removed the hover state color change for stripes. After further alignment with teams, this has been
revertedreworked.Why are we making this change?
To make sure the design spec is implemented equally and consistently.
Related PRs:
EuiDataGridandEuiTablehover consistent #8769Screenshots
Hover states for striped data grids, in light and dark mode.
Impact to users
🟢 No direct impact. These visual changes ensure UI remains almost the same while encouraging consistency.
QA
Remove or strikethrough items that do not apply to your PR.
General checklist
Checked in both MacOS and Windows high contrast modes(emulate forced colors if you do not have access to a Windows machine.)Checked in mobileChecked for accessibility including keyboard-only and screenreader modesAdded documentationProps have proper autodocs (using@defaultif default values are missing) and playground togglesChecked Code Sandbox works for any docs examplesAdded or updated jest and cypress testsUpdated visual regression tests(not needed)If applicable, added the breaking change issue label (and filled out the breaking change checklist)If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)