Skip to content

Conversation

@acstll
Copy link
Contributor

@acstll acstll commented Aug 27, 2025

Summary

This PR adds a visual change to EuiDataGrid related to the background color of rows on hover, specifically when using stripes (stripes prop equals true).

The original design spec within the Visual Refresh effort removed the hover state color change for stripes. After further alignment with teams, this has been reverted reworked.

Why are we making this change?

To make sure the design spec is implemented equally and consistently.

Related PRs:

Screenshots

Hover states for striped data grids, in light and dark mode. Screenshot 2025-08-27 at 10 49 48 Screenshot 2025-08-27 at 10 49 45 Screenshot 2025-08-27 at 10 50 21 Screenshot 2025-08-27 at 10 50 09

Impact to users

🟢 No direct impact. These visual changes ensure UI remains almost the same while encouraging consistency.

QA

Remove or strikethrough items that do not apply to your PR.

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in both MacOS and Windows high contrast modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

@acstll acstll self-assigned this Aug 27, 2025
acstll added a commit to elastic/kibana that referenced this pull request Aug 27, 2025
@acstll
Copy link
Contributor Author

acstll commented Aug 28, 2025

@JoseLuisGJ for awareness, just in case there's any work to do related to this, in the current code/design parity effort 👀

@acstll acstll marked this pull request as ready for review August 28, 2025 11:04
@acstll acstll requested a review from a team as a code owner August 28, 2025 11:04
@mgadewoll mgadewoll self-requested a review August 28, 2025 13:41

buttonGroupFocusColor: SEMANTIC_COLORS.plainLight,

dataGridRowStripesBackgroundHover: SEMANTIC_COLORS.shade130,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Where was this color defined? The design specs states shade-15 but I don't see any specs for dark mode 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, it's indeed missing from the spec so I "made it up" deriving it from other light/dark pairs, so it needs validation from design (I was expecting this to come up during testing in Kibana, to adjust if needed, but both Kate and Laura are on PTO)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oki, yeah then let's wait for @ek-so to confirm or provide required specs once she's back 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both! 130 is the correct color.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @acstll

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @acstll

@acstll acstll merged commit 921983d into elastic:main Sep 8, 2025
5 checks passed
tkajtoch added a commit to elastic/kibana that referenced this pull request Sep 11, 2025
- `@elastic/eui`: `v106.4.0` ⏩ `v106.5.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Package updates

## [`v106.5.0`](https://github.com/elastic/eui/releases/v106.5.0)

- Added an optional `offset` prop to `EuiToolTip` to allow customizing
the distance (in pixels) between the tooltip and its anchor.
([#8988](elastic/eui#8988))
- Updated `EuiDataGrid` hover styles when `stripes={true}` to ensure a
visible background color change on hover
([#8983](elastic/eui#8983))

**Bug fixes**

- Fixed a 1ms time shift on `EuiSuperDatePicker` when using the quick
select time window steps
([#8985](elastic/eui#8985))
- Fixed a visual issue in `EuiSuperDatePicker` with `isQuickSelectOnly`
enabled, where delimiter padding caused an unexpected empty container
([#8985](elastic/eui#8985))

**Accessibility**

- Changed the close button position in `EuiModal` to allow for the modal
title to be perceivable first
([#8954](elastic/eui#8954))
- Added screen reader hint text on `EuiModal` to indicate closing
behavior ([#8954](elastic/eui#8954))

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
KodeRad pushed a commit to KodeRad/kibana that referenced this pull request Sep 15, 2025
- `@elastic/eui`: `v106.4.0` ⏩ `v106.5.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Package updates

## [`v106.5.0`](https://github.com/elastic/eui/releases/v106.5.0)

- Added an optional `offset` prop to `EuiToolTip` to allow customizing
the distance (in pixels) between the tooltip and its anchor.
([elastic#8988](elastic/eui#8988))
- Updated `EuiDataGrid` hover styles when `stripes={true}` to ensure a
visible background color change on hover
([elastic#8983](elastic/eui#8983))

**Bug fixes**

- Fixed a 1ms time shift on `EuiSuperDatePicker` when using the quick
select time window steps
([elastic#8985](elastic/eui#8985))
- Fixed a visual issue in `EuiSuperDatePicker` with `isQuickSelectOnly`
enabled, where delimiter padding caused an unexpected empty container
([elastic#8985](elastic/eui#8985))

**Accessibility**

- Changed the close button position in `EuiModal` to allow for the modal
title to be perceivable first
([elastic#8954](elastic/eui#8954))
- Added screen reader hint text on `EuiModal` to indicate closing
behavior ([elastic#8954](elastic/eui#8954))

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
weronikaolejniczak added a commit to elastic/kibana that referenced this pull request Sep 16, 2025
- `@elastic/eui`: `v106.5.0` ⏩ `v106.6.0`
- `@elastic/eui-theme-borealis`: `v3.3.2` ⏩ `v3.4.0`
- `@elastic/eslint-plugin-eui`: `v2.3.0` ⏩ `v2.4.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Package updates

### `@elastic/eui`

#### [`v106.6.0`](https://github.com/elastic/eui/releases/v106.6.0)

**Accessibility**

- Removed focus state styles for `iconOnClick` on `EuiBadge` to improve
color contrast in dark mode
([#9004](elastic/eui#9004))

### `@elastic/eui-theme-borealis`

####
[`v3.4.0`](https://www.npmjs.com/package/@elastic/eui-theme-borealis/v/3.4.0)

- Updated values for component tokens
([#8983](elastic/eui#8983))
  - `dataGridRowStripesBackgroundHover`
  - `dataGridRowStripesBackgroundStripedHover`
  - `dataGridRowStripesBackgroundSelectHover`
  - `dataGridRowStripesBackgroundHover`
  - `dataGridRowStripesBackgroundStripedHover`

### `@elastic/eslint-plugin-eui`

####
[`v2.4.0`](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.4.0)

- Added new `callout-announce-on-mount` rule.
([#9005](elastic/eui#9005))
- Added new `no-unnamed-interactive-element` rule.
([#8973](elastic/eui#8973))
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Sep 24, 2025
- `@elastic/eui`: `v106.4.0` ⏩ `v106.5.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Package updates

## [`v106.5.0`](https://github.com/elastic/eui/releases/v106.5.0)

- Added an optional `offset` prop to `EuiToolTip` to allow customizing
the distance (in pixels) between the tooltip and its anchor.
([elastic#8988](elastic/eui#8988))
- Updated `EuiDataGrid` hover styles when `stripes={true}` to ensure a
visible background color change on hover
([elastic#8983](elastic/eui#8983))

**Bug fixes**

- Fixed a 1ms time shift on `EuiSuperDatePicker` when using the quick
select time window steps
([elastic#8985](elastic/eui#8985))
- Fixed a visual issue in `EuiSuperDatePicker` with `isQuickSelectOnly`
enabled, where delimiter padding caused an unexpected empty container
([elastic#8985](elastic/eui#8985))

**Accessibility**

- Changed the close button position in `EuiModal` to allow for the modal
title to be perceivable first
([elastic#8954](elastic/eui#8954))
- Added screen reader hint text on `EuiModal` to indicate closing
behavior ([elastic#8954](elastic/eui#8954))

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Sep 24, 2025
- `@elastic/eui`: `v106.5.0` ⏩ `v106.6.0`
- `@elastic/eui-theme-borealis`: `v3.3.2` ⏩ `v3.4.0`
- `@elastic/eslint-plugin-eui`: `v2.3.0` ⏩ `v2.4.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Package updates

### `@elastic/eui`

#### [`v106.6.0`](https://github.com/elastic/eui/releases/v106.6.0)

**Accessibility**

- Removed focus state styles for `iconOnClick` on `EuiBadge` to improve
color contrast in dark mode
([elastic#9004](elastic/eui#9004))

### `@elastic/eui-theme-borealis`

####
[`v3.4.0`](https://www.npmjs.com/package/@elastic/eui-theme-borealis/v/3.4.0)

- Updated values for component tokens
([elastic#8983](elastic/eui#8983))
  - `dataGridRowStripesBackgroundHover`
  - `dataGridRowStripesBackgroundStripedHover`
  - `dataGridRowStripesBackgroundSelectHover`
  - `dataGridRowStripesBackgroundHover`
  - `dataGridRowStripesBackgroundStripedHover`

### `@elastic/eslint-plugin-eui`

####
[`v2.4.0`](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.4.0)

- Added new `callout-announce-on-mount` rule.
([elastic#9005](elastic/eui#9005))
- Added new `no-unnamed-interactive-element` rule.
([elastic#8973](elastic/eui#8973))
niros1 pushed a commit to elastic/kibana that referenced this pull request Sep 30, 2025
- `@elastic/eui`: `v106.4.0` ⏩ `v106.5.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Package updates

## [`v106.5.0`](https://github.com/elastic/eui/releases/v106.5.0)

- Added an optional `offset` prop to `EuiToolTip` to allow customizing
the distance (in pixels) between the tooltip and its anchor.
([#8988](elastic/eui#8988))
- Updated `EuiDataGrid` hover styles when `stripes={true}` to ensure a
visible background color change on hover
([#8983](elastic/eui#8983))

**Bug fixes**

- Fixed a 1ms time shift on `EuiSuperDatePicker` when using the quick
select time window steps
([#8985](elastic/eui#8985))
- Fixed a visual issue in `EuiSuperDatePicker` with `isQuickSelectOnly`
enabled, where delimiter padding caused an unexpected empty container
([#8985](elastic/eui#8985))

**Accessibility**

- Changed the close button position in `EuiModal` to allow for the modal
title to be perceivable first
([#8954](elastic/eui#8954))
- Added screen reader hint text on `EuiModal` to indicate closing
behavior ([#8954](elastic/eui#8954))

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
niros1 pushed a commit to elastic/kibana that referenced this pull request Sep 30, 2025
- `@elastic/eui`: `v106.5.0` ⏩ `v106.6.0`
- `@elastic/eui-theme-borealis`: `v3.3.2` ⏩ `v3.4.0`
- `@elastic/eslint-plugin-eui`: `v2.3.0` ⏩ `v2.4.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Package updates

### `@elastic/eui`

#### [`v106.6.0`](https://github.com/elastic/eui/releases/v106.6.0)

**Accessibility**

- Removed focus state styles for `iconOnClick` on `EuiBadge` to improve
color contrast in dark mode
([#9004](elastic/eui#9004))

### `@elastic/eui-theme-borealis`

####
[`v3.4.0`](https://www.npmjs.com/package/@elastic/eui-theme-borealis/v/3.4.0)

- Updated values for component tokens
([#8983](elastic/eui#8983))
  - `dataGridRowStripesBackgroundHover`
  - `dataGridRowStripesBackgroundStripedHover`
  - `dataGridRowStripesBackgroundSelectHover`
  - `dataGridRowStripesBackgroundHover`
  - `dataGridRowStripesBackgroundStripedHover`

### `@elastic/eslint-plugin-eui`

####
[`v2.4.0`](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.4.0)

- Added new `callout-announce-on-mount` rule.
([#9005](elastic/eui#9005))
- Added new `no-unnamed-interactive-element` rule.
([#8973](elastic/eui#8973))
rylnd pushed a commit to rylnd/kibana that referenced this pull request Oct 17, 2025
- `@elastic/eui`: `v106.5.0` ⏩ `v106.6.0`
- `@elastic/eui-theme-borealis`: `v3.3.2` ⏩ `v3.4.0`
- `@elastic/eslint-plugin-eui`: `v2.3.0` ⏩ `v2.4.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Package updates

### `@elastic/eui`

#### [`v106.6.0`](https://github.com/elastic/eui/releases/v106.6.0)

**Accessibility**

- Removed focus state styles for `iconOnClick` on `EuiBadge` to improve
color contrast in dark mode
([elastic#9004](elastic/eui#9004))

### `@elastic/eui-theme-borealis`

####
[`v3.4.0`](https://www.npmjs.com/package/@elastic/eui-theme-borealis/v/3.4.0)

- Updated values for component tokens
([elastic#8983](elastic/eui#8983))
  - `dataGridRowStripesBackgroundHover`
  - `dataGridRowStripesBackgroundStripedHover`
  - `dataGridRowStripesBackgroundSelectHover`
  - `dataGridRowStripesBackgroundHover`
  - `dataGridRowStripesBackgroundStripedHover`

### `@elastic/eslint-plugin-eui`

####
[`v2.4.0`](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.4.0)

- Added new `callout-announce-on-mount` rule.
([elastic#9005](elastic/eui#9005))
- Added new `no-unnamed-interactive-element` rule.
([elastic#8973](elastic/eui#8973))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants