Skip to content

Enable multi database in android #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 15, 2023
Merged

Enable multi database in android #1318

merged 14 commits into from
May 15, 2023

Conversation

@milaGGL
Copy link
Contributor

@milaGGL milaGGL commented May 11, 2023 •
edited
Loading

  • add database_name_ private property to Firestoreinternal class to store database name on creation and read on delete
  • update firestore GetInstance JNI method call in android folder to include database id string
  • update validation test to fix github check failure

@milaGGL milaGGL changed the title initial code Enable multi database in android May 12, 2023
@milaGGL milaGGL marked this pull request as ready for review May 12, 2023 20:50
@milaGGL milaGGL requested a review from tom-andersen May 12, 2023 20:58
tom-andersen
tom-andersen requested changes May 15, 2023
View reviewed changes
@milaGGL milaGGL requested a review from tom-andersen May 15, 2023 18:39
tom-andersen
tom-andersen requested changes May 15, 2023
View reviewed changes
@milaGGL milaGGL requested a review from tom-andersen May 15, 2023 20:11
tom-andersen
tom-andersen approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@tom-andersen tom-andersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milaGGL milaGGL merged commit 1e4ae74 into mila/MultiDB May 15, 2023
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label May 15, 2023
@github-actions
Copy link

github-actions bot commented May 15, 2023 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @milaGGL on commit 1e4ae74
Last updated: Mon May 15 15:39 PDT 2023
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  ServerTimestampTest.TestServerTimestampsCanReturnPreviousValue
[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
[TEST] [FLAKINESS] [Android] [2/3 os: ubuntu macos] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 15, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 15, 2023
@firebase firebase locked and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tom-andersen tom-andersen tom-andersen approved these changes

Assignees

@tom-andersen tom-andersen

@milaGGL milaGGL

Labels

tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@milaGGL @tom-andersen