Fix DistributedDP Optimizer for Fast Gradient Clipping #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60484128 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60484128 |
HuanyuZhang
pushed a commit
to HuanyuZhang/opacus
that referenced
this pull request
Aug 1, 2024
) Summary: Pull Request resolved: meta-pytorch#662 The step function incorrectly called "original_optimizer.original_optimizer" instead of "original_optimizer". Fixed it now. Differential Revision: D60484128
063f6b1 to
26b4f71
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60484128 |
HuanyuZhang
pushed a commit
to HuanyuZhang/opacus
that referenced
this pull request
Aug 1, 2024
) Summary: Pull Request resolved: meta-pytorch#662 The step function incorrectly called "original_optimizer.original_optimizer" instead of "original_optimizer". Fixed it now. Differential Revision: D60484128
26b4f71 to
d43b625
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60484128 |
d43b625 to
6a674f9
Compare
HuanyuZhang
pushed a commit
to HuanyuZhang/opacus
that referenced
this pull request
Aug 2, 2024
) Summary: Pull Request resolved: meta-pytorch#662 The step function incorrectly called "original_optimizer.original_optimizer" instead of "original_optimizer". Fixed it now. Differential Revision: D60484128
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60484128 |
HuanyuZhang
pushed a commit
to HuanyuZhang/opacus
that referenced
this pull request
Aug 2, 2024
) Summary: Pull Request resolved: meta-pytorch#662 The step function incorrectly called "original_optimizer.original_optimizer" instead of "original_optimizer". Fixed it now. Differential Revision: D60484128
6a674f9 to
7ac5199
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60484128 |
HuanyuZhang
pushed a commit
to HuanyuZhang/opacus
that referenced
this pull request
Aug 2, 2024
) Summary: Pull Request resolved: meta-pytorch#662 The step function incorrectly called "original_optimizer.original_optimizer" instead of "original_optimizer". Fixed it now. Reviewed By: HuanyuZhang Differential Revision: D60484128
7ac5199 to
4f70e6d
Compare
) Summary: Pull Request resolved: meta-pytorch#662 The step function incorrectly called "original_optimizer.original_optimizer" instead of "original_optimizer". Fixed it now. Reviewed By: HuanyuZhang Differential Revision: D60484128
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60484128 |
4f70e6d to
d52d7a2
Compare
Contributor
|
This pull request has been merged in eb94674. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The step function incorrectly called "original_optimizer.original_optimizer" instead of "original_optimizer". Fixed it now.
Differential Revision: D60484128