Fix "to_standard_module" for Ghost Clipping #754
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74019695 |
HuanyuZhang
added a commit
to HuanyuZhang/opacus
that referenced
this pull request
May 1, 2025
Summary: Bug on removing attributes associated with GC. Differential Revision: D74019695
6bcba23 to
1cdebca
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74019695 |
HuanyuZhang
added a commit
to HuanyuZhang/opacus
that referenced
this pull request
May 6, 2025
Summary: Issue [meta-pytorch#749](meta-pytorch#749) Under FGC, we use ``del p.grad_sample`` to release used per-sample gradients. However, when running ``to_standard_module``, w/o new changes, it will lead to attribute not found errors. Reviewed By: iden-kalemaj Differential Revision: D74019695
1cdebca to
55c54d7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74019695 |
HuanyuZhang
added a commit
to HuanyuZhang/opacus
that referenced
this pull request
May 6, 2025
Summary: Issue [meta-pytorch#749](meta-pytorch#749) Under FGC, we use ``del p.grad_sample`` to release used per-sample gradients. However, when running ``to_standard_module``, w/o new changes, it will lead to attribute not found errors. Reviewed By: iden-kalemaj Differential Revision: D74019695
55c54d7 to
d9477a3
Compare
Summary: Pull Request resolved: meta-pytorch#754 Issue [meta-pytorch#749](meta-pytorch#749) Under FGC, we use ``del p.grad_sample`` to release used per-sample gradients. However, when running ``to_standard_module``, w/o new changes, it will lead to attribute not found errors. Reviewed By: iden-kalemaj Differential Revision: D74019695
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74019695 |
d9477a3 to
c6d6570
Compare
Contributor
|
This pull request has been merged in 4acea9f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Bug on removing attributes associated with GC.
Differential Revision: D74019695