Provide warning about restriction on unclipped_num_std for adaptive clipping #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74590917 |
iden-kalemaj
added a commit
to iden-kalemaj/opacus
that referenced
this pull request
May 13, 2025
…lipping (meta-pytorch#758) Summary: See discussion in Github issue: meta-pytorch#757 1. Throw error when noise_mulitplier > 2 * unclipped_num_std 2. Provide logic for case when noise_multiplier = 0 Differential Revision: D74590917
b8f3e32 to
7d4d3fe
Compare
…lipping (meta-pytorch#758) Summary: Pull Request resolved: meta-pytorch#758 See discussion in Github issue: meta-pytorch#757 1. Throw error when noise_mulitplier > 2 * unclipped_num_std 2. Provide logic for case when noise_multiplier = 0 Differential Revision: D74590917
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74590917 |
7d4d3fe to
5d5b21e
Compare
Contributor
|
This pull request has been merged in ce4605b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
See discussion in Github issue: #757
Throw error when noise_mulitplier > 2 * unclipped_num_std
Provide logic for case when noise_multiplier = 0
Differential Revision: D74590917