add a valueToQuotedString overload #1397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… things like a string_view more directly.
BillyDonahue
requested changes
Mar 25, 2022
Co-authored-by: Billy Donahue <BillyDonahue@users.noreply.github.com>
BillyDonahue
approved these changes
Mar 28, 2022
Contributor
BillyDonahue
left a comment
There was a problem hiding this comment.
This looks fine to me. It doesn't break backward compatibility AFAICT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to take a string length to support things like a string_view more directly.
The valueToQuotedString method is useful for a few other items related to JSON generation. In many cases we had to use it directly from a std::string_view, which in the present code required conversion to a string, then using the c_str and it computing the length. So this PR adds an overload that allows direct specification of the string length. and a few places in the code that could take advantage of it.