Skip to content

Conversation

@12rambau
Copy link
Collaborator

@12rambau 12rambau commented Oct 27, 2022

@12rambau 12rambau marked this pull request as ready for review October 27, 2022 07:00
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - though we have a bunch of notebooks-specific CSS in the execution page as well:

https://github.com/12rambau/pydata-sphinx-theme/blob/notebook/src/pydata_sphinx_theme/assets/styles/extensions/_execution.scss

Should we merge and rename execution to notebooks?

@12rambau
Copy link
Collaborator Author

I would merge nbsphinx and myst-nb together in _notebooks and I'would keep jupyter-sphinx (and later jupyterlite) in _execution

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I think the new notebooks file makes sense 👍

@choldgraf choldgraf merged commit 50873e7 into pydata:main Nov 3, 2022
@12rambau 12rambau deleted the notebook branch November 4, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wide notebook outputs should have a max-width and scroll

2 participants