Skip to content

Conversation

@gabalafou
Copy link
Collaborator

Follow up to #1823

Copy link
Member

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was expecting #1823 to get rebased/squashed down to 2 commits (1 to add stylelint hooks, one for everything else) but this works too --- It's 4 lines instead of 1, no big deal

@drammock drammock merged commit 1d29813 into pydata:main May 28, 2024
@gabalafou gabalafou deleted the blame-ignore-stylelint-fixes branch June 3, 2024 13:34
@gabalafou
Copy link
Collaborator Author

was expecting #1823 to get rebased/squashed down to 2 commits

I wasn't 100% sure if both the auto and manual fixes should be git-blame-ignored so I pushed that decision to this PR, plus I was a little tired of wrangling the commit history of that PR, didn't want to spend more time fiddling with the commits, possibly rebasing incorrectly, possibly triggering a CI commit, etc. etc.

ivanov pushed a commit to ivanov/pydata-sphinx-theme that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants