👌 Add external link icon to external links in sidebar #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Result:
|
Collaborator
|
This sounds like a good idea to use the css approach! Agreed we should do the same for the navbar and remove the custom beautiful soup bits as much as possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the "external link" icon to external links in the sidebar. We already have this for the navbar (actually using a specific configuration option to add those, while we could probably also do that through sphinx' toctree, but that's for another PR). But this adds it for the sidebar as well (eg like sphinx-book-theme and furo do as well).
In sphinx-book-theme we explicitly add the icon to the html, like we do for the navbar here as well (using beautifulsoup, see https://github.com/executablebooks/sphinx-book-theme/blob/39aaaa3e4d908fe7be8b7378ad474d8c6b86aa16/sphinx_book_theme/__init__.py#L126-L130). But in this PR I took the approach of Furo to add
::afterthe link with CSS, but using the same icon/styling we already use in this theme / sphinx-book-theme.