repo-sync-2025-05-07T10:24:02+0800 #301
Conversation
There was a problem hiding this comment.
Hello @oeqqwq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request focuses on updating the SecretFlow PSI library. It includes dependency updates in the MODULE.bazel file, modifications to the RELEASE.md file to reflect version changes and feature updates, and the removal of a configuration option in the RR22 protocol. Additionally, there are updates to the documentation, specifically in the Chinese translation of the PSI protocol introduction, and some updates to example configurations.
Highlights
- Dependency Updates: The
MODULE.bazelfile has been updated to remove specific dependencies and overrides, streamlining the build process. - Release Notes: The
RELEASE.mdfile has been modified to reflect changes in versions, API updates, feature additions, improvements, and bug fixes. - Configuration Changes: The
skip_duplicates_checkoption has been removed from the RR22 protocol configuration files. - Documentation Updates: The Chinese translation of the PSI protocol introduction has been updated with minor text and formatting adjustments.
Changelog
Click here to see the changelog
- MODULE.bazel
- Removed gRPC override.
- Removed brpc and org_interconnection dependencies.
- Removed prometheus-cpp dependency.
- RELEASE.md
- Added release notes for v0.5.0beta, v0.4.2beta, and v0.4.0beta.
- Documented API changes, feature additions, improvements, and bug fixes.
- benchmark/docker-compose/config/rr22_receiver_recovery.json
- Removed
skip_duplicates_checkoption.
- Removed
- benchmark/docker-compose/config/rr22_sender_recovery.json
- Removed
skip_duplicates_checkoption.
- Removed
- docs/locale/zh_CN/LC_MESSAGES/development/psi_protocol_intro.po
- Updated POT-Creation-Date to 2025-04-28.
- Made minor text and formatting adjustments to the Chinese translation.
- docs/locale/zh_CN/LC_MESSAGES/reference/psi_config.po
- Removed deprecated messages related to DDH, ecdh-oprf, and Blazing Fast PSI.
- docs/locale/zh_CN/LC_MESSAGES/user_guide/apsi_benchmark.po
- Updated POT-Creation-Date to 2025-04-28.
- Made minor text adjustments to the Chinese translation.
- docs/locale/zh_CN/LC_MESSAGES/user_guide/faq.po
- Updated POT-Creation-Date to 2025-04-28.
- Made minor text adjustments to the Chinese translation.
- docs/locale/zh_CN/LC_MESSAGES/whatsnew.po
- Updated POT-Creation-Date to 2025-04-28.
- docs/reference/launch_config.md
- Removed trailing whitespace.
- docs/reference/pir_config.md
- Removed trailing whitespace.
- docs/reference/psi_config.md
- Removed trailing whitespace.
- docs/reference/psi_v2_config.md
- Removed InternalRecoveryRecord and RecoveryCheckpoint sections.
- Removed skip_duplicates_check field.
- docs/user_guide/psi_v2.rst
- Removed skip_duplicates_check option from example configurations.
- docs/user_guide/psi_v2_benchmark.md
- Removed skip_duplicates_check option from example configurations.
- examples/pir/config/dk_pir_receiver_online.json
- Removed trailing whitespace.
- examples/pir/config/dk_pir_sender_offline.json
- Removed trailing whitespace.
- examples/psi/config/ecdh_receiver_inner_join.json
- Removed
skip_duplicates_checkoption.
- Removed
- examples/psi/config/ecdh_receiver_recovery.json
- Removed
skip_duplicates_checkoption.
- Removed
- examples/psi/config/ecdh_sender_inner_join.json
- Removed
skip_duplicates_checkoption.
- Removed
- examples/psi/config/ecdh_sender_recovery.json
- Removed
skip_duplicates_checkoption.
- Removed
- examples/psi/config/kkrt_receiver_recovery.json
- Removed
skip_duplicates_checkoption.
- Removed
- examples/psi/config/kkrt_sender_recovery.json
- Removed
skip_duplicates_checkoption.
- Removed
- examples/psi/config/rr22_receiver_recovery.json
- Removed
skip_duplicates_checkoption.
- Removed
- examples/psi/config/rr22_sender_recovery.json
- Removed
skip_duplicates_checkoption.
- Removed
- psi/algorithm/ecdh/ecdh_psi.cc
- Removed ic_mode related code.
- psi/algorithm/ecdh/ecdh_psi.h
- Removed ic_mode option.
- psi/algorithm/ecdh/receiver.cc
- Removed ic_mode related code.
- psi/algorithm/ecdh/sender.cc
- Removed ic_mode related code.
- psi/apps/psi_launcher/launch.cc
- Removed ic_mode parameter from RunLegacyPsi function.
- Modified UbExecConfToUbconf to set server and client receive results.
- psi/apps/psi_launcher/launch.h
- Removed ic_mode parameter from RunLegacyPsi function.
- psi/apps/psi_launcher/psi_test.cc
- Updated test case to reflect changes in UbPsiExecuteConfig.
- psi/config/ub_psi.h
- Added server_receive_result and client_receive_result fields.
- psi/interface.cc
- Removed skip_duplicates_check related code.
- Modified check_hash_digest to support unique keys input check.
- psi/legacy/bucket_psi.cc
- Removed ic_mode related code.
- psi/legacy/bucket_psi.h
- Removed ic_mode related code.
- psi/legacy/bucket_psi_test.cc
- Removed run_in_ic_mode parameter.
- psi/proto/psi_v2.proto
- Removed skip_duplicates_check field.
- psi/utils/BUILD.bazel
- Added join_processor_test target.
- psi/utils/communication.cc
- Removed interconnection protocol related code.
- psi/utils/communication.h
- Removed interconnection protocol related code.
- psi/utils/join_processor.cc
- Added a check for stat.join_intersection_count before sorting.
- psi/utils/join_processor_test.cc
- Added new test file for join_processor.
- psi/utils/sync.cc
- Added AllGatherFlag function.
- psi/utils/table_utils.cc
- Set duplicate_key_cnt to 0 in KeyInfo::Make.
- psi/utils/table_utils_test.cc
- Added DupKeyCnt check in TableUtilTest.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A sync of code, a version's flight,
Dependencies aligned, shining bright.
Old configs fade,
New features cascade,
A cleaner system, day and night.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request removes the skip_duplicates_check option from the psi_v2 config, updates dependencies, and makes various documentation improvements. The changes seem reasonable and well-organized.
Summary of Findings
- Removal of
skip_duplicates_check: Theskip_duplicates_checkoption has been removed from the psi_v2 config. It's important to ensure that the logic depending on this flag is either no longer needed or has been adapted to the new configuration. I did not comment on this change since I was instructed not to add review comments for low severity issues. - Documentation updates: Several documentation files have been updated with improved translations and formatting. This enhances the clarity and usability of the documentation. I did not comment on this change since I was instructed not to add review comments for low severity issues.
- Dependency updates: Several dependencies in the MODULE.bazel file have been updated. It's crucial to verify that these updates don't introduce any compatibility issues or security vulnerabilities. I did not comment on this change since I was instructed not to add review comments for low severity issues.
Merge Readiness
The pull request appears to be in good shape for merging, but it's important to verify that the removal of skip_duplicates_check doesn't introduce any regressions. Also, please ensure that the dependency updates are safe and don't introduce any new issues. I am unable to directly approve this pull request, and users should have others review and approve this code before merging.
No description provided.