Skip to content

Conversation

@tyrone-yu
Copy link
Collaborator

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @tyrone-yu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on maintenance and minor bug fixes. It updates the Bazel version to 7.6.1 and synchronizes the MODULE.bazel.lock file. Additionally, it includes a crucial fix in the SEAL PIR algorithm's MultiplyPowerOfX function to ensure correct polynomial coefficient handling during shifts, and a small initialization improvement in a C++ synchronization utility.

Highlights

  • Bazel Version Update: The USE_BAZEL_VERSION in .bazeliskrc has been updated from 7.5.0 to 7.6.1.
  • Dependency Lock File Update: The MODULE.bazel.lock file was modified, specifically updating the bzlTransitiveDigest for rules_rust.
  • SEAL PIR Algorithm Fix: The MultiplyPowerOfX function in seal_pir.cc was updated to correctly handle cases where the index for polynomial shifting is greater than or equal to N (polynomial modulus degree), including negating coefficients and using actual_index. The type of N was also changed from int to size_t.
  • C++ Header Inclusion: Added #include <cstddef> to psi/algorithm/sealpir/seal_pir.cc.
  • Synchronization Utility Initialization: The res variable in the SyncWait function within psi/utils/sync.h is now explicitly initialized.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily involves dependency updates, including an upgrade of the Bazel version. It also contains a few C++ code modifications. The most significant change is in psi/algorithm/sealpir/seal_pir.cc, which refactors the logic for polynomial multiplication. My review focuses on these C++ changes. I've identified a correctness bug in seal_pir.cc that could lead to incorrect cryptographic computations under certain conditions, as well as a performance issue related to memory allocation within a loop. The change in psi/utils/sync.h is a good improvement for safer initialization. Please see the detailed comments.

Copy link
Contributor

@FollyCoolly FollyCoolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huocun-ant huocun-ant self-requested a review September 22, 2025 07:04
Copy link
Collaborator

@huocun-ant huocun-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tyrone-yu tyrone-yu merged commit a3c21a3 into main Sep 22, 2025
6 checks passed
@tyrone-yu tyrone-yu deleted the yyq/sync-code branch September 22, 2025 07:14
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants