-
Notifications
You must be signed in to change notification settings - Fork 581
fix(select): handle async option creation in creatable mode #6200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
4
commits into
develop
Choose a base branch
from
copilot/fix-issue-adding-options
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: liweijie0812 <10710889+liweijie0812@users.noreply.github.com>
Co-authored-by: liweijie0812 <10710889+liweijie0812@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix error when adding options with timer
fix(select): handle async option creation in creatable mode
Nov 28, 2025
Copilot finished work on behalf of
liweijie0812
November 28, 2025 13:01
Collaborator
|
@copilot 测试案例格式根据仓库规范来,可以参考form的 |
Co-authored-by: liweijie0812 <10710889+liweijie0812@users.noreply.github.com>
Contributor
Author
Copilot finished work on behalf of
liweijie0812
November 28, 2025 13:10
commit: |
Collaborator
TDesign Component Site Preview Open
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

🤔 这个 PR 的性质是?
🔗 相关 Issue
https://github.com/Tencent/tdesign-vue-next/issues/6228
💡 需求背景和解决方案
When using
creatablemode with an asynconCreatecallback (e.g., setTimeout to validate with backend), the component crashes becausegetSelectedOptions()is called before the option exists inoptionsList.Fix: When
createAbleis true, construct the option object directly from props instead of callinggetSelectedOptions():This ensures
onChangereceives valid option data regardless of async callback timing.Test case: Added test case under
describe('@event', ...)section with proper namingdescribe('onCreate #6228', ...), following the repository test format standards used by other event tests likeonClearandonChange.📝 更新日志
tdesign-vue-next
@tdesign-vue-next/chat
@tdesign-vue-next/auto-import-resolver
☑️ 请求合并前的自查清单
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.