Skip to content

fix(popconfirm): 修复快速点击按钮时 getComputedStyle 报错 #6224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+15 −5
Open

fix(popconfirm): 修复快速点击按钮时 getComputedStyle 报错 #6224

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6aadd9f
Initial plan
Copilot Nov 30, 2025
f7eb6ea
fix(popconfirm): add null check for getComputedStyle in useRipple hook
Copilot Nov 30, 2025
e78a212
fix(popconfirm): add additional null checks for getComputedStyle calls
Copilot Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(popconfirm): add additional null checks for getComputedStyle calls 
Co-authored-by: liweijie0812 <10710889+liweijie0812@users.noreply.github.com>
  • Loading branch information
@liweijie0812
Copilot and liweijie0812 committed Nov 30, 2025
commit e78a21224403eece02430479e5e083eb26f4e468
7 changes: 6 additions & 1 deletion packages/shared/hooks/useRipple/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ export function useRipple(el: Ref<HTMLElement>, fixedRippleColor?: Ref<string>)
)
return;

// Check again if element is still valid before calling getComputedStyle
if (!(dom instanceof Element)) return;
const elStyle = getComputedStyle(dom);

const elBorder = parseInt(elStyle.borderWidth, 10);
Expand Down Expand Up @@ -109,7 +111,10 @@ export function useRipple(el: Ref<HTMLElement>, fixedRippleColor?: Ref<string>)
}

// fix position
const initPosition = dom.style.position ? dom.style.position : getComputedStyle(dom).position;
let initPosition = dom.style.position;
if (!initPosition && dom instanceof Element) {
initPosition = getComputedStyle(dom).position;
}
if (initPosition === '' || initPosition === 'static') {
// eslint-disable-next-line no-param-reassign
dom.style.position = 'relative';
Expand Down
Loading