fix: elementOverflow code
#1104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
requested changes
Sep 26, 2024
| container = defaultGetContainer(element); | ||
| } | ||
| if (!container) { | ||
| return "none"; |
Collaborator
There was a problem hiding this comment.
can this happen or should it be an error?
| ) { | ||
| let container = getContainer?.(); | ||
| if (!container) { | ||
| container = defaultGetContainer(element); |
Collaborator
There was a problem hiding this comment.
why not just say getContainer = defaultGetContainer in the function signature?
| !container.classList.contains("bn-suggestion-menu") && | ||
| !container.classList.contains("bn-grid-suggestion-menu") | ||
| ) { | ||
| return; |
Collaborator
There was a problem hiding this comment.
let's make explicit with return undefined (instead of empty return statement)
| const defaultGetContainer = (element: HTMLElement) => { | ||
| let container: HTMLElement = element; | ||
|
|
||
| while ( |
Collaborator
There was a problem hiding this comment.
I think you can just use https://developer.mozilla.org/en-US/docs/Web/API/Element/closest
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.