-
Notifications
You must be signed in to change notification settings - Fork 115
schedule a meeting with cal.com #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Zhiqiang ZHOU <im@strrl.dev>
Signed-off-by: Zhiqiang ZHOU <im@strrl.dev>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: STRRL The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new "Contact Us" page with an embedded Cal.com scheduler and a floating "Schedule a Meeting" button, and adds a corresponding nav link and script include.
- Added
static/js/cal-floating-button.jsto load and configure a floating Cal.com widget - Created
src/pages/contact.jsfor the Contact Us page, embedding an iframe scheduler and listing other channels - Updated
docusaurus.config.jsto include a "Contact Us" navbar item and load the floating button script
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| static/js/cal-floating-button.js | New script for integrating a Cal.com floating button |
| src/pages/contact.js | New Contact Us page with embedded scheduling iframe |
| docusaurus.config.js | Added navbar link & script entry for floating button |
Comments suppressed due to low confidence (3)
static/js/cal-floating-button.js:2
- [nitpick] Variable names 'p', 'a', and 'ar' are ambiguous; consider renaming them to more descriptive names like 'enqueue', 'target', and 'args' to improve readability.
let p = function (a, ar) {
static/js/cal-floating-button.js:1
- [nitpick] Add a brief JSDoc or comment above this IIFE explaining its purpose and how it initializes the Cal.com embed script to aid future maintainers.
;(function (C, A, L) {
src/pages/contact.js:5
- Consider adding unit or integration tests for the Contact page to ensure key elements (headings, iframe, links) render and behave as expected.
export default function Contact() {
✅ Deploy Preview for chaos-mesh-website-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Zhiqiang ZHOU <im@strrl.dev>
|
Hi @g1eny0ung I have updated the implementation with @calcom/embed-react, but there should be some polish on the styling I think <3 PTAL! |
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
|
@STRRL I have also updated the style. PTAL :) |
|
that's cool! LGTM! I think we could merge this PR now? |
|
Sure! |
design/style part might need adjustments, PTAL @g1eny0ung ❤️