Skip to content

Conversation

@dvaldivia1
Copy link

@dvaldivia1 dvaldivia1 commented Jun 12, 2025

Describe your changes

I have implemented a basic getter and setter for the Elevation Angle of the camera.

Issue number:

Fix #1419

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated timestamp

Continuous integration

Please check the checkbox of the CI you want to run, then push again on your branch.

  • Style checks
  • Fast CI
  • Coverage cached CI
  • Analysis cached CI
  • WASM docker CI
  • Android docker CI
  • macOS Intel cached CI
  • macOS ARM cached CI
  • Windows cached CI
  • Linux cached CI
  • Other cached CI

@github-actions
Copy link

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

@mwestphal
Copy link
Member

@dvaldivia1 please keep the PR template when creating a PR. I've recreated it for you.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove all not needed files. You may want to use a local .gitignore to avoid commiting them.

@mwestphal
Copy link
Member

@dvaldivia1 i suppose this is not ready for review ? I've switched your PR to a draft one :)

@mwestphal mwestphal marked this pull request as draft June 12, 2025 05:20
@dvaldivia1
Copy link
Author

yes it is just a draft thank you!

@mwestphal
Copy link
Member

Hi @dvaldivia1

Do you need any help moving forward ? :)

@mwestphal
Copy link
Member

Hi @dvaldivia1

Do you need any help moving forward ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add getters for camera parameters

2 participants