Add support for temporal mesh in vtkF3DMemoryMesh and scene API #2561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are modifying libf3d public API! |
Member
Author
|
\ci fast |
0454de1 to
a89c03e
Compare
mwestphal
reviewed
Oct 23, 2025
library/public/scene.h
Outdated
| virtual scene& add(const std::filesystem::path& filePath) = 0; | ||
| virtual scene& add(const std::vector<std::filesystem::path>& filePath) = 0; | ||
| virtual scene& add(const std::vector<std::string>& filePathStrings) = 0; | ||
| virtual scene& add(const std::vector<mesh_t>& mesh, double timeStep) = 0; |
Member
There was a problem hiding this comment.
im not sure to follow, why is there multple meshes for a single timestep ?
Member
|
Need any help moving forward @0xfedcafe ? |
47433bf to
ff3de6e
Compare
Member
|
Hi @0xfedcafe , still working on this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add support for temporal mesh in vtkF3DMemoryMesh and scene API. I haven't updated bindings yet as I haven't figured out which was to be updated or how.
Issue ticket number and link if any
#2443 , #2443
Checklist for finalizing the PR
.github/workflows/versions.json, I have updatedtimestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.