Add chunk size as an argument for training #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinjzhang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86459877. |
5d78c69 to
600c284
Compare
kevinjzhang
added a commit
to kevinjzhang/openzl-1
that referenced
this pull request
Nov 11, 2025
Summary: Refactors parsing such that it is more streamlined to add parameters to a profile. Adds chunk size via profile args `chunk-size-mb=*`. This always displays: ``` Chunking is not currently implemented for all profiles. Ignoring parameter if unimplemented. Chunking is implemented for the following profiles: csv ``` Differential Revision: D86459877
kevinjzhang
added a commit
to kevinjzhang/openzl-1
that referenced
this pull request
Nov 11, 2025
Summary: Refactors parsing such that it is more streamlined to add parameters to a profile and profiles have profile args which are parsed separately (as global args). The alternative is to pass in the command as arguments (since profile is not actually a command). Adds chunk size via profile args `--chunk-size-mb` flag. This always displays: ``` Chunking is not currently implemented for all profiles. Ignoring parameter if unimplemented. Chunking is implemented for the following profiles: csv ``` Differential Revision: D86459877
600c284 to
ce58bcb
Compare
kevinjzhang
added a commit
to kevinjzhang/openzl-1
that referenced
this pull request
Nov 12, 2025
Summary: Refactors parsing such that it is more streamlined to add parameters to a profile and profiles have profile args which are parsed separately (as global args). The alternative is to pass in the command as arguments (since profile is not actually a command). Adds chunk size via profile args `--chunk-size-mb` flag. This always displays: ``` Chunking is not currently implemented for all profiles. Ignoring parameter if unimplemented. Chunking is implemented for the following profiles: csv ``` Differential Revision: D86459877
3e115eb to
426a4e6
Compare
kevinjzhang
added a commit
to kevinjzhang/openzl-1
that referenced
this pull request
Nov 17, 2025
Summary: Refactors parsing such that it is more streamlined to add parameters to a profile and profiles have profile args which are parsed separately (as global args). The alternative is to pass in the command as arguments (since profile is not actually a command). Adds chunk size via profile args `--chunk-size-mb` flag. This always displays: ``` Chunking is not currently implemented for all profiles. Ignoring parameter if unimplemented. Chunking is implemented for the following profiles: csv ``` Differential Revision: D86459877
426a4e6 to
408b913
Compare
kevinjzhang
added a commit
to kevinjzhang/openzl-1
that referenced
this pull request
Nov 21, 2025
Summary: Refactors parsing such that it is more streamlined to add parameters to a profile and profiles have profile args which are parsed separately (as global args). The alternative is to pass in the command as arguments (since profile is not actually a command). Adds chunk size via profile args `--chunk-size-mb` flag. This always displays: ``` Chunking is not currently implemented for all profiles. Ignoring parameter if unimplemented. Chunking is implemented for the following profiles: csv ``` Differential Revision: D86459877
Summary: Refactors parsing such that it is more streamlined to add parameters to a profile and profiles have profile args which are parsed separately (as global args). The alternative is to pass in the command as arguments (since profile is not actually a command). Adds chunk size via profile args `--chunk-size-mb` flag. This always displays: ``` Chunking is not currently implemented for all profiles. Ignoring parameter if unimplemented. Chunking is implemented for the following profiles: csv ``` Differential Revision: D86459877
408b913 to
7e3ec0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Refactors parsing such that it is more streamlined to add parameters to a profile.
Adds chunk size via profile args
chunk-size-mb=*. This always displays:Differential Revision: D86459877