trampoline trace hooks from Tracer to a new ChunkTrace class #230
+733
−456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Victor-C-Zhang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87656706. |
Victor-C-Zhang
added a commit
to Victor-C-Zhang/openzl-1
that referenced
this pull request
Nov 24, 2025
…k#230) Summary: The idea of the tracer was to be an RAII holder of state for an individual trace because the `CompressionTraceHooks` class could take multiple traces. Now that a trace contains multiple independent chunk traces, this is the rationale to do the same for `ChunkTrace`. (Or maybe `ChunkTracer`?) This will make it easier to process for visualization as well, since all the stream, graph, and codec IDs will line up, making it easier to make UI optimizations like merging chunks with identical trees or diffing between chunks. Differential Revision: D87656706
a9ef3c3 to
4f62b5d
Compare
Victor-C-Zhang
added a commit
to Victor-C-Zhang/openzl-1
that referenced
this pull request
Nov 25, 2025
…k#230) Summary: The idea of the tracer was to be an RAII holder of state for an individual trace because the `CompressionTraceHooks` class could take multiple traces. Now that a trace contains multiple independent chunk traces, this is the rationale to do the same for `ChunkTrace`. (Or maybe `ChunkTracer`?) This will make it easier to process for visualization as well, since all the stream, graph, and codec IDs will line up, making it easier to make UI optimizations like merging chunks with identical trees or diffing between chunks. Reviewed By: terrelln Differential Revision: D87656706
Victor-C-Zhang
added a commit
to Victor-C-Zhang/openzl-1
that referenced
this pull request
Nov 25, 2025
…k#230) Summary: The idea of the tracer was to be an RAII holder of state for an individual trace because the `CompressionTraceHooks` class could take multiple traces. Now that a trace contains multiple independent chunk traces, this is the rationale to do the same for `ChunkTrace`. (Or maybe `ChunkTracer`?) This will make it easier to process for visualization as well, since all the stream, graph, and codec IDs will line up, making it easier to make UI optimizations like merging chunks with identical trees or diffing between chunks. Reviewed By: terrelln Differential Revision: D87656706
…k#230) Summary: The idea of the tracer was to be an RAII holder of state for an individual trace because the `CompressionTraceHooks` class could take multiple traces. Now that a trace contains multiple independent chunk traces, this is the rationale to do the same for `ChunkTrace`. (Or maybe `ChunkTracer`?) This will make it easier to process for visualization as well, since all the stream, graph, and codec IDs will line up, making it easier to make UI optimizations like merging chunks with identical trees or diffing between chunks. Reviewed By: terrelln Differential Revision: D87656706
4f62b5d to
fd6b14f
Compare
Victor-C-Zhang
added a commit
to Victor-C-Zhang/openzl-1
that referenced
this pull request
Nov 25, 2025
…k#230) Summary: The idea of the tracer was to be an RAII holder of state for an individual trace because the `CompressionTraceHooks` class could take multiple traces. Now that a trace contains multiple independent chunk traces, this is the rationale to do the same for `ChunkTrace`. (Or maybe `ChunkTracer`?) This will make it easier to process for visualization as well, since all the stream, graph, and codec IDs will line up, making it easier to make UI optimizations like merging chunks with identical trees or diffing between chunks. Reviewed By: terrelln Differential Revision: D87656706
Victor-C-Zhang
added a commit
to Victor-C-Zhang/openzl-1
that referenced
this pull request
Dec 1, 2025
…k#230) Summary: The idea of the tracer was to be an RAII holder of state for an individual trace because the `CompressionTraceHooks` class could take multiple traces. Now that a trace contains multiple independent chunk traces, this is the rationale to do the same for `ChunkTrace`. (Or maybe `ChunkTracer`?) This will make it easier to process for visualization as well, since all the stream, graph, and codec IDs will line up, making it easier to make UI optimizations like merging chunks with identical trees or diffing between chunks. Reviewed By: terrelln Differential Revision: D87656706
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The idea of the tracer was to be an RAII holder of state for an individual trace because the
CompressionTraceHooksclass could take multiple traces.Now that a trace contains multiple independent chunk traces, this is the rationale to do the same for
ChunkTrace. (Or maybeChunkTracer?) This will make it easier to process for visualization as well, since all the stream, graph, and codec IDs will line up, making it easier to make UI optimizations like merging chunks with identical trees or diffing between chunks.Differential Revision: D87656706