Skip to content
This repository was archived by the owner on May 13, 2025. It is now read-only.

Module fix #396

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Module fix #396

wants to merge 8 commits into from

Conversation

@lvdmaaten
Copy link
Contributor

@lvdmaaten lvdmaaten commented Aug 21, 2022

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs change / refactoring / dependency upgrade

Motivation and Context / Related issue

In newer ONNX versions, some ops changed from using attributes to using inputs. This PR contains changes in crypten.nn.Modules to accommodate those changes.

How Has This Been Tested (if it applies)

Unit tests pass: python -m unittest -v test.test_nn.TestTTP.test_pytorch_modules. Relying on CI for remaining tests.

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lvdmaaten @facebook-github-bot