Skip to content
This repository was archived by the owner on May 13, 2025. It is now read-only.

Conversation

@gillesoldano
Copy link

@gillesoldano gillesoldano commented May 16, 2023

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs change / refactoring / dependency upgrade

Motivation and Context / Related issue

It replaces the deprecated,unofficial "sklearn" dependency with "scikit-learn"

#454

How Has This Been Tested (if it applies)

I have run the test suite with the command python3 -u -m unittest discover -s test -p '*test*.py'

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

Attached are the Dockerfile of the image I used to run the test suite and the test outputs
Dockerfile.txt
err.txt
out.txt

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants