Skip to content

Conversation

@matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Nov 9, 2025

Experimental idea: add a doc page for each locale. This would be an easy way to show off how Faker works in various languages, and maybe also be useful for SEO?

Screenshot 2025-11-09 at 19 20 20 Screenshot 2025-11-09 at 19 20 13

@netlify
Copy link

netlify bot commented Nov 9, 2025

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 265754c
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/691687ba7f41750008027176
😎 Deploy Preview https://deploy-preview-3654.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@matthewmayer matthewmayer self-assigned this Nov 9, 2025
@codecov
Copy link

codecov bot commented Nov 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.97%. Comparing base (24aa11f) to head (265754c).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3654   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2994     2994           
  Lines      236305   236305           
  Branches      939      941    +2     
=======================================
  Hits       236248   236248           
  Misses         57       57           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matthewmayer matthewmayer added c: docs Improvements or additions to documentation c: feature Request for new feature labels Nov 10, 2025
@matthewmayer matthewmayer marked this pull request as ready for review November 10, 2025 15:10
@matthewmayer matthewmayer requested a review from a team as a code owner November 10, 2025 15:10
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting idea. A bummer right now is that when visiting e.g. https://deploy-preview-3654.fakerjs.dev/locales/de.html the left sidebar is gone, and so as a user I loose UX / context.

@Shinigami92
Copy link
Member

LGTM, but CI error

@matthewmayer
Copy link
Contributor Author

Don't really understand the error

@Shinigami92
Copy link
Member

Don't really understand the error

Some scripts that are running are checking and generating stuff in the docs folder. And if there is a diff mismatch, then it fails as there is e.g. a non-committed change.

@matthewmayer
Copy link
Contributor Author

Fixed thanks

Shinigami92
Shinigami92 previously approved these changes Nov 12, 2025
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great feature. 👍
I have some questions (sorry, Vue noob here) and suggestions. See comments.


Some general extensions I could see being added to this feature in the future:

  • use the already existing "RefreshButton" component to reload the examples inline
  • use Slots or TemplateRefs for easier/more fine grained post processing
  • improve UX by giving the user feedback on which page they are (currently no entry is highlighted on the sidebar)

matthewmayer and others added 2 commits November 14, 2025 08:20
Co-authored-by: DivisionByZero <leyla.jaehnig@gmx.de>
@matthewmayer
Copy link
Contributor Author

i did consider using the RefreshButton but the code seems sufficiently different for it to not really help that much. For example, on the other docs pages we render the results which are already in the code block comments first, and only load the client-side JS on demand to refresh.

But for locale pages we want to dynamically load on first load of the page.

@xDivisionByZerox xDivisionByZerox added this to the v10.x milestone Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: docs Improvements or additions to documentation c: feature Request for new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants