-
-
Notifications
You must be signed in to change notification settings - Fork 1k
docs: add a doc page for each locale #3654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3654 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 2994 2994
Lines 236305 236305
Branches 939 941 +2
=======================================
Hits 236248 236248
Misses 57 57 🚀 New features to boost your workflow:
|
Shinigami92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting idea. A bummer right now is that when visiting e.g. https://deploy-preview-3654.fakerjs.dev/locales/de.html the left sidebar is gone, and so as a user I loose UX / context.
|
LGTM, but CI error |
|
Don't really understand the error |
|
Fixed thanks |
xDivisionByZerox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a great feature. 👍
I have some questions (sorry, Vue noob here) and suggestions. See comments.
Some general extensions I could see being added to this feature in the future:
- use the already existing "RefreshButton" component to reload the examples inline
- use Slots or TemplateRefs for easier/more fine grained post processing
- improve UX by giving the user feedback on which page they are (currently no entry is highlighted on the sidebar)
Co-authored-by: DivisionByZero <leyla.jaehnig@gmx.de>
|
i did consider using the RefreshButton but the code seems sufficiently different for it to not really help that much. For example, on the other docs pages we render the results which are already in the code block comments first, and only load the client-side JS on demand to refresh. But for locale pages we want to dynamically load on first load of the page. |

Experimental idea: add a doc page for each locale. This would be an easy way to show off how Faker works in various languages, and maybe also be useful for SEO?