Block npx and disable npm scripts in devcontainer #21163
+22
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add security hardening to the devcontainer by: - Disabling npx command to prevent arbitrary package execution - Setting ignore-scripts=true for npm and yarn to block lifecycle scripts This prevents potential security risks from running untrusted scripts during package installation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Replace npx tsc and npx prettier with direct calls since npx is being disabled for security reasons. TypeScript and Prettier are already in devDependencies, so they can be called directly through yarn/npm. Changes: - components/gitpod-db: npx tsc -> tsc - components/ws-manager-bridge: npx tsc -> tsc - components/server: npx tsc -> tsc, npx prettier -> prettier 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
|
@jespino Let's shelve this one a little, we need to take a closer look at the build pipeline to unblock it again. |
Member
|
I will have somebody look into this from Classic 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add security hardening to the devcontainer by:
This prevents potential security risks from running untrusted scripts during package installation.
Changes
.devcontainer/Dockerfileto disable npx and set npm/yarn to ignore scriptsdev/image/Dockerfilewith the same security hardeningTest plan
🤖 Generated with Claude Code