Skip to content

Conversation

@tina77fritz
Copy link

Motivation

PrivacyAccountant.compose validates event but does not validate the
count argument. Invalid count values (e.g. floats, zero, negative) cause
errors to surface deeper in the accounting stack, making them harder to
debug.

This PR adds early input validation for count with clear error messages,
while preserving the existing chainable return self.

Changes

  • Validate that count is an integer (TypeError otherwise)
  • Validate that count is positive (ValueError otherwise)
  • Add corresponding tests in privacy_accountant_test.py using a minimal
    dummy accountant

This is a backward-compatible improvement to input safety.

@google-cla
Copy link

google-cla bot commented Nov 20, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant