Made compatible with Go modules #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pendence on github.com/wangzitian0/golang-gin-starter-kit.
wangzitian0
approved these changes
Mar 30, 2021
Collaborator
wangzitian0
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the nice change!
Contributor
Author
|
My pleasure. Thank you for writing the nice example code.
Regards,
Paulo
…On Tue, Mar 30, 2021 at 1:24 PM wangzitian0 ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM! Thanks for the nice change!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#23 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD4LPKNM577GOGYX4WLT7LTGICNZANCNFSM42BZUR3A>
.
|
Collaborator
|
@pvillela Do you have time to take a look at the badges at the readme including coverage and CI? Seems it failed after this PR.. |
Contributor
Author
|
I clicked on the badges but I don't have access. Besides, I'm not familiar
with travis. Nonetheless, I suspect the problem is due to changes in some
of the dependencies. I went back to your previous commit on master,
regenerated go.mod, and synced it with vendor.json (go mod vendor). After
that, I again removed the dependence on the starter-kit repo. Again, all
unit tests passed. I have pushed a new PR with this.
…On Wed, Mar 31, 2021 at 1:34 AM wangzitian0 ***@***.***> wrote:
@pvillela <https://github.com/pvillela> Do you have time to take a look
at the badges at the readme including coverage and CI? Seems it failed
after this PR..
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD4LPK6HHJ6DIPCUSQPEITTGKX4RANCNFSM42BZUR3A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added go.mod, removed vendors and dependence on github.com/wangzitian0/golang-gin-starter-kit. All unit tests pass.