suppress console.error while creating InferenceSession #1468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I invested some time into #1236 and from what I see there are three ways how we could solve this:
suppress console.error while creating InferenceSession
while copying the wasm .mjs file we could overwrite the line that cases the console.error
change the wasm library .mjs file.
We (or the ONNX maintainers) would have to make changes directly in their library. This would certainly be the cleanest solution, but we would be dependent on third parties. 2. I would not recommend this, as it could disrupt the copying process if changes are made within the ONNX library.
That's why solution one would be my favorite. It looks a bit messy or hacky, but honestly, I think it's the simplest solution.