Skip to content

Show if end date is present date #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2020
Merged

Show if end date is present date #7

merged 1 commit into from
Mar 11, 2020

Conversation

@jvandenaardweg
Copy link
Contributor

@jvandenaardweg jvandenaardweg commented Mar 11, 2020 •
edited
Loading

This PR will let you know if the "end date" is the present date, so if that position is still ongoing.

Apr 2017 – Present

will translate to:

"startDate": "2017-04-01T00:00:00+02:00",
"endDate": null,
"endDateIsPresent": true,
"durationInDays": 1076,

Nov 2019 – Feb 2020

will translate to:

"startDate": "2019-11-01T00:00:00+01:00",
"endDate": "2020-02-01T00:00:00+01:00",
"endDateIsPresent": false,
"durationInDays": 93,

@jvandenaardweg jvandenaardweg merged commit 70cc8d7 into master Mar 11, 2020
@jvandenaardweg jvandenaardweg deleted the feature/correct-present-date branch March 11, 2020 08:30
jvandenaardweg pushed a commit that referenced this pull request May 29, 2023
@brainsucker
Merge pull request #7 from jvandenaardweg/feature/correct-present-date
5f6e25e 
Show if end date is present date
jvandenaardweg pushed a commit that referenced this pull request May 29, 2023
Merge pull request #7 from jvandenaardweg/feature/correct-present-date
f9a2b0d 
Show if end date is present date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jvandenaardweg