Refactor: Replace manual memory management with smart pointers #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced all `malloc`/`free` calls with `std::unique_ptr` to leverage RAII for memory management. Used custom deleters where needed to handle specific free functions, such as `stbi_image_free` and `free_sd_ctx`. Simplified resource cleanup by removing explicit `free` calls, reducing the risk of memory leaks and improving code readability. Adjusted function calls to align with smart pointer usage, ensuring compatibility and preventing raw pointer access Signed-off-by: Eric Curtin <ecurtin@redhat.com>
|
So true. I keep getting memory leaks bc it allocates memory for images but im getting crash when i trying to free them |
Contributor
|
This has good intentions, but the PR has many unrelated and inappropriate changes, like this one:
And things that look a lot like something an LLM would mess up (for instance, it's removing the whole img2vid call). I realize this was submitted a long time ago, but if you can clean it up I'll review it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced all
malloc/freecalls withstd::unique_ptrto leverage RAII for memory management. Used custom deleters where needed to handle specific free functions, such asstbi_image_freeandfree_sd_ctx. Simplified resource cleanup by removing explicitfreecalls, reducing the risk of memory leaks and improving code readability. Adjusted function calls to align with smart pointer usage, ensuring compatibility and preventing raw pointer access