Skip to content

feat(http/body-eos): EosRef<'a, E>: Clone + Copy #4312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(http/body-eos): EosRef<'a, E>: Clone + Copy #4312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions linkerd/http/body-eos/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,3 +130,16 @@ where
};
}
}

// === impl EosRef ===

/// A reference to the end of a stream can be cheaply cloned.
///
/// Each of the variants are empty tags, or immutable references.
impl<'a, E> Clone for EosRef<'a, E> {
fn clone(&self) -> Self {
*self
}
}
Comment on lines +136 to +143
Copy link
Member Author

@cratelyn cratelyn Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://gist.github.com/cratelyn/ff1e2d4299ae2626c229dc31aa21597b

#[derive(Clone)] will only work if E: Clone. this is manually implemented because we want this reference to be clonable even if E: Clone does not hold.


impl<'a, E> Copy for EosRef<'a, E> {}
Loading