Skip to content

[Network] Internalfabric get fix #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −2
Open

[Network] Internalfabric get fix #3125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6978187
fix: internalfabric get
cheina97 Sep 11, 2025
86a4fbe
fix: network test delete namespace increased timeout
cheina97 Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/gateway/fabric/geneve/internalfabric.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ func getInternalFabric(ctx context.Context, cl client.Client, gatewayName, remot
return nil, fmt.Errorf("unable to get the internal fabric %q: %w", remoteID, err)
}

if err == nil {
return internalFabric, nil
}

err = cl.Get(ctx, client.ObjectKey{
Name: gatewayName,
Namespace: ns,
Expand Down
4 changes: 2 additions & 2 deletions pkg/liqoctl/test/network/setup/namespace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ func RemoveNamespace(ctx context.Context, cl *client.Client) error {
if err := cl.Consumer.Delete(ctx, ns); err != nil {
return err
}
timeout, cancel := context.WithTimeout(ctx, 1*time.Minute)
timeout, cancel := context.WithTimeout(ctx, 2*time.Minute)
defer cancel()
if err := wait.PollUntilContextCancel(timeout, 1*time.Second, true, func(ctx context.Context) (done bool, err error) {
if err := wait.PollUntilContextCancel(timeout, 10*time.Second, true, func(ctx context.Context) (done bool, err error) {
if err := cl.Consumer.Get(ctx, ctrlclient.ObjectKeyFromObject(ns), ns); err != nil {
return ctrlclient.IgnoreNotFound(err) == nil, nil
}
Expand Down
Loading