Skip to content

Fix BatchMemoryManager length #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Fix BatchMemoryManager length #641

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
22ea05a
Fix BatchMemoryManager length
Mar 22, 2024
e2d36d5
undo styling
dwahdany Mar 22, 2024
4185457
undo styling
dwahdany Mar 22, 2024
53eb040
refactor: math instead of numpy
May 17, 2024
83139c3
fix: styling
dwahdany May 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions opacus/utils/batch_memory_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
)
from torch.utils.data import BatchSampler, DataLoader, Sampler


class BatchSplittingSampler(Sampler[List[int]]):
"""
Samples according to the underlying instance of ``Sampler``, but splits
Expand Down Expand Up @@ -70,14 +69,16 @@ def __iter__(self):

def __len__(self):
if isinstance(self.sampler, BatchSampler):
return int(
return math.ceil(
len(self.sampler) * (self.sampler.batch_size / self.max_batch_size)
)
elif isinstance(self.sampler, UniformWithReplacementSampler) or isinstance(
self.sampler, DistributedUniformWithReplacementSampler
):
expected_batch_size = self.sampler.sample_rate * self.sampler.num_samples
return int(len(self.sampler) * (expected_batch_size / self.max_batch_size))
return math.ceil(
len(self.sampler) * (expected_batch_size / self.max_batch_size)
)

return len(self.sampler)

Expand Down